From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] multistring support in gui_label
Date: Wed, 03 Apr 2013 09:20:14 +0200 [thread overview]
Message-ID: <515BD82E.6080805@gmail.com> (raw)
In-Reply-To: <1433564.XLGijaNbUn@icedphoenix>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On 22.03.2013 16:58, Vladimir Testov wrote:
> + word_width = label_string_width (buf, font, l_lastend, end);
> + if (isvertical || (str_width + word_width > l_width)) // can't add new word
> + {
Please don't use // comments. This code completely forgets the cases
when even the first word doesn't fit in the available space.
The code as whole breaks some unicode concepts like e.g. bidi stack.
Could you reuse the already available line-vreaking algorithm in
normal/term.c and normal/charset.c ? Since the line-breaking is
artificially disabled for labels it should require only minor
adjustments to be reenabled.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2013-04-03 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 15:58 [PATCH] multistring support in gui_label Vladimir Testov
2013-04-03 7:20 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-04-16 9:04 Vladimir Testov
2013-04-16 17:10 ` Andrey Borzenkov
2013-04-17 6:56 ` Vladimir Testov
2013-04-17 7:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-17 9:02 ` Vladimir Testov
2013-04-17 11:16 ` Vladimir Testov
2013-04-17 11:39 ` Vladimir Testov
2013-04-17 12:41 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-23 11:58 ` Vladimir Testov
2013-03-21 17:17 Vladimir Testov
2013-03-21 18:12 ` Gerard Butler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515BD82E.6080805@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).