From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UNJDf-0003iG-40 for mharc-grub-devel@gnu.org; Wed, 03 Apr 2013 04:38:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNJDX-0003eC-JM for grub-devel@gnu.org; Wed, 03 Apr 2013 04:38:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNJDR-0004VB-J2 for grub-devel@gnu.org; Wed, 03 Apr 2013 04:38:51 -0400 Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:56108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNJDR-0004Ut-BL for grub-devel@gnu.org; Wed, 03 Apr 2013 04:38:45 -0400 Received: by mail-ea0-f177.google.com with SMTP id q14so545503eaj.8 for ; Wed, 03 Apr 2013 01:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=uOdO0/lY80MHXWRyaNasQJMgOXPiNUrUgxBivtPManw=; b=fn5YWcuqEAfCWR0qNzMkb9o29LsqP9dLqt3p14CxA7YfcKyMqgdckq3ARFouVEDW+2 mEvxojtm8QDJSKPxznh/uSQEohNoT7jSqf5DUT3mMrYmGP4gu0MNS+wy3/s9rCaRSDtI KZKU+nOCnPUViEO3AViicYh8XHQtRKuehU7tIg+uUPfPGs6mGfdNO39LIomS7Fj8xpgr 7ek3PRKJ6mKPa9X1GQENWoouJzSidTqWjxCtjVRuTe6gXYM7VAEWOFT9FPnFA0e9mglL BcmmibLP8EfrRIjyH5KOmNY0Dl7WwUSBqejLLE7C8Thmc4I/UOR+qMixaJS3Y5x6m6fJ 5Swg== X-Received: by 10.15.36.135 with SMTP id i7mr1724140eev.34.1364978324549; Wed, 03 Apr 2013 01:38:44 -0700 (PDT) Received: from debian.x201.phnet (77-88.1-85.cust.bluewin.ch. [85.1.88.77]) by mx.google.com with ESMTPS id q5sm6818773eeo.17.2013.04.03.01.38.42 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 03 Apr 2013 01:38:43 -0700 (PDT) Message-ID: <515BD82E.6080805@gmail.com> Date: Wed, 03 Apr 2013 09:20:14 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] multistring support in gui_label References: <1433564.XLGijaNbUn@icedphoenix> In-Reply-To: <1433564.XLGijaNbUn@icedphoenix> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigD738E76A5F5E4719ED6E4C9F" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2013 08:38:57 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD738E76A5F5E4719ED6E4C9F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 22.03.2013 16:58, Vladimir Testov wrote: > + word_width =3D label_string_width (buf, font, l_lastend, end); > + if (isvertical || (str_width + word_width > l_width)) // can't add= new word > + { Please don't use // comments. This code completely forgets the cases when even the first word doesn't fit in the available space. The code as whole breaks some unicode concepts like e.g. bidi stack. Could you reuse the already available line-vreaking algorithm in normal/term.c and normal/charset.c ? Since the line-breaking is artificially disabled for labels it should require only minor adjustments to be reenabled. --------------enigD738E76A5F5E4719ED6E4C9F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlFb2C4ACgkQNak7dOguQgm8lwD8C1GS/jE0mOlo2i64SdScXsIB h1dgLlDXvy9EsPbVGDEBAJq932EWu+wb7bqMV51xYAwZMqbMg4VqYUHpyON12AZJ =WpSL -----END PGP SIGNATURE----- --------------enigD738E76A5F5E4719ED6E4C9F--