From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UO0md-000856-Lf for mharc-grub-devel@gnu.org; Fri, 05 Apr 2013 03:09:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO0ma-000810-HQ for grub-devel@gnu.org; Fri, 05 Apr 2013 03:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UO0mY-0002NG-9z for grub-devel@gnu.org; Fri, 05 Apr 2013 03:09:56 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:58602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO0mY-0002M7-3O for grub-devel@gnu.org; Fri, 05 Apr 2013 03:09:54 -0400 Received: by mail-ee0-f53.google.com with SMTP id c13so1229936eek.26 for ; Fri, 05 Apr 2013 00:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=JRyYDjccccSjVuu9QqaMWwa2I3H2LxwY47wq3jXf820=; b=TCja7HAxC4XhnjGf7qtUl0YDYrHiG5IhKUENmbXpAWfDprTZcQcIG1/FENpB28R203 02W9DQZb8qaAgTbRyuaef6TTLVJeVmkeNBOw0Opl7LqudX+ukURCeAeBwUhYhPs0uzd0 pwc4GQlOFs2zRUl5Fvd3jf1DbUflpTg+AU6AS4A74LVxaAxQn4dKUeu/41oMEt7LMFVH kY/UAgvOkyhIl+QXTphqaY9PeQeNnF6lw//wG6KzfMUMGCM+WkhSKt94ySg3Z5SSBxWE Jw+SXEvH4Bri68oKnQ4WYsG0rPYqasX+FvZ9dMFnMdq8gSAgDM+Y0HZls6V+T6HkeV2J dhNg== X-Received: by 10.15.111.202 with SMTP id cj50mr17034503eeb.6.1365145792909; Fri, 05 Apr 2013 00:09:52 -0700 (PDT) Received: from debian.x201.phnet (45-233.197-178.cust.bluewin.ch. [178.197.233.45]) by mx.google.com with ESMTPS id n2sm13787672eeo.10.2013.04.05.00.09.49 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Apr 2013 00:09:51 -0700 (PDT) Message-ID: <515E78B2.4030208@gmail.com> Date: Fri, 05 Apr 2013 09:09:38 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Make grub_efidisk_get_device_name() work on 4K native disks. References: <1365004386-24760-1-git-send-email-pjones@redhat.com> <20130403230346.01b981c2@opensuse.site> <20130404174117.GC1202@fenchurch.internal.datastacks.com> <20130404221441.452eb3b8@opensuse.site> In-Reply-To: <20130404221441.452eb3b8@opensuse.site> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigFBB222309E131695B4A9F012" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.53 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2013 07:09:58 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFBB222309E131695B4A9F012 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04.04.2013 20:14, Andrey Borzenkov wrote: > =D0=92 Thu, 4 Apr 2013 13:52:05 -0400 > Peter Jones =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 >> On Wed, Apr 03, 2013 at 11:03:46PM +0400, Andrey Borzenkov wrote: >>> =D0=92 Wed, 3 Apr 2013 11:53:06 -0400 >>> Peter Jones =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> >>>> When we have 4kB sectors instead of 512b sectors, hd.partition_start= and >>>> grub_partition_get_start() won't match - the latter assumes 512-byte= >>>> sectors, and the former gives us the correct number based on the >>>> physical media's sector size. So when we have to compare them, we n= eed >>>> to compensate. >>>> >>>> Signed-off-by: Peter Jones >>>> --- >>>> grub-core/disk/efi/efidisk.c | 10 ++++++---- >>>> 1 file changed, 6 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidi= sk.c >>>> index 77ab5b0..a905b52 100644 >>>> --- a/grub-core/disk/efi/efidisk.c >>>> +++ b/grub-core/disk/efi/efidisk.c >>>> @@ -791,11 +791,13 @@ grub_efidisk_get_device_name (grub_efi_handle_= t *handle) >>>> auto int find_partition (grub_disk_t disk, const grub_partiti= on_t part); >>>> =20 >>> >>> You need to rebase to current trunk which does not use nested functio= ns >>> anymore. Also in current trunk there is second use of >>> grub_partition_get_start() which looks like it has the same issue. >> >> Oh, indeed, you're right, that has changed. Although the current tree= looks >> like it already takes this in to consideration. >> >=20 > Hmm ... I do not see it. Your change looks still necessary. >=20 Probably your copy is a bit old. I adjusted and committed his patch. >> So nevermind then :) >> >> Thanks for having a look. >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --------------enigFBB222309E131695B4A9F012 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlFeeLgACgkQNak7dOguQgmguAD/RgMEhp2RlTkS87TnLyc/cae0 gZgeJZJX9JkCYYrQVbYBAKZ/TE1MNSdPdw3ueM/E/K73wr7uxAUbmoNJfDWCdVFe =5MJA -----END PGP SIGNATURE----- --------------enigFBB222309E131695B4A9F012--