From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Command documentation part 1.
Date: Fri, 05 Apr 2013 09:45:38 +0200 [thread overview]
Message-ID: <515E8122.8030302@gmail.com> (raw)
In-Reply-To: <20130405114149.075bc332@opensuse.site>
[-- Attachment #1: Type: text/plain, Size: 2137 bytes --]
On 05.04.2013 09:41, Andrey Borzenkov wrote:
> В Wed, 03 Apr 2013 11:11:44 +0200
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>
>> On 30.03.2013 09:46, Andrey Borzenkov wrote:
>>
>>> В Tue, 26 Mar 2013 11:48:37 +0100
>>> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>>>
>>>>> +@deffn Command background_color color
>>>>> +Set background color for active terminal. For valid color specifications see
>>>>> +@pxref{Theme file format, ,Colors}. Background color can be changed only when
>>>>> +using @samp{gfxterm} for terminal output.
>>>>> +@end deffn
>>>>
>>>> There is a confusion between the background behind the letters
>>>> (background_color_normal/_highlight variables) and solid color used as
>>>> background image (background_color command). This description would
>>>> probably suggest former rather than the latter.
>>>>
>>>
>>> I'm afraid this exceeds my language skills. This is called background
>>> color for what I know. Any native English speaker to chime in?
>>>
>>
>> I don't think it's about skills. It doesn't seem to be a clear term to
>> distinguish the both usages. I think a sentence explaining which colour
>> is meant is the best way to deal with the situation.
>>
>
> Is it OK?
>
> @@ -3483,6 +3483,10 @@ If @samp{superusers} is empty, this command returns true. @xref{Security}.
> Set background color for active terminal. For valid color specifications see
> @pxref{Theme file format, ,Colors}. Background color can be changed only when
> using @samp{gfxterm} for terminal output.
> +
> +This command sets color of empty areas without text. Text background color
> +is controlled by environment variables @var{color_normal}, @var{color_highlight},
> +@var{menu_color_normal}, @var{menu_color_highlight}. @xref{Special environment variables}.
> @end deffn
>
Yes. Could you send the patch as whole so I can commit it?
>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2013-04-05 7:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 13:08 Command documentation policy Andrey Borzenkov
2013-01-22 17:12 ` Colin Watson
2013-01-22 17:16 ` Colin Watson
2013-01-29 10:25 ` Command documentation part 1 Andrey Borzenkov
2013-02-09 11:48 ` Francesco Lavra
2013-02-24 7:40 ` Andrey Borzenkov
2013-03-07 11:06 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-03-08 11:45 ` Andrey Borzenkov
2013-03-10 16:45 ` Andrey Borzenkov
2013-03-26 10:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-03-30 8:46 ` Andrey Borzenkov
2013-04-03 9:11 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-05 7:41 ` Andrey Borzenkov
2013-04-05 7:45 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-04-05 7:57 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515E8122.8030302@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).