From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UPcNj-0005Hj-9g for mharc-grub-devel@gnu.org; Tue, 09 Apr 2013 13:30:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPcNf-000595-9D for grub-devel@gnu.org; Tue, 09 Apr 2013 13:30:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPcNd-0001tR-HD for grub-devel@gnu.org; Tue, 09 Apr 2013 13:30:50 -0400 Received: from mail-ee0-f48.google.com ([74.125.83.48]:50580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPcNd-0001tF-AM for grub-devel@gnu.org; Tue, 09 Apr 2013 13:30:49 -0400 Received: by mail-ee0-f48.google.com with SMTP id b15so3099013eek.21 for ; Tue, 09 Apr 2013 10:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=3h1xqiGs/pU14Y7/e2cud+hRjz6HuY350BW9kQNUOyA=; b=HaAjO3/U1tGjsvnryW6/cDtamLREQYhyijUnpYGHCn8mE8XeXx2JuMKf8P0OYhQDpK l95S4Z5/2oTc7GJZ3f5efvGLdtAKu0y9O2Nk1M6gyAuP2Oc9/60ZYDVEnI+5vs84wtxR NiihnRShAmxm/L7ab6NJtHLGI+0Rf2581j3K46CcneLiKW4/jPhSR/k9JG8I+67nu5UP mIAko2gsi8bGDWlopUPnDsYrE5XRLungUK8NVNfb5J+ZW5uyUy36t7OjWutlCkJMSVKb LF8xxJENkomgUW+GsUsgsOuH/CKveEF9p2bONzuYfrjaVuJ6eCYrCK7WGMYfHrQu3Y5E Fjfw== X-Received: by 10.15.32.67 with SMTP id z43mr52689007eeu.24.1365528648405; Tue, 09 Apr 2013 10:30:48 -0700 (PDT) Received: from debian.x201.phnet (245-188.1-85.cust.bluewin.ch. [85.1.188.245]) by mx.google.com with ESMTPS id q5sm39226888eeo.17.2013.04.09.10.30.47 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Apr 2013 10:30:47 -0700 (PDT) Message-ID: <51645046.6070403@gmail.com> Date: Tue, 09 Apr 2013 19:30:46 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Leif Lindholm , The development of GRUB 2 Subject: Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms References: <5159B4CB.2040300@gmail.com> <20130403180757.GO23069@rocoto.smurfnet.nu> <515C8AB7.7000602@gmail.com> <20130404125414.GP23069@rocoto.smurfnet.nu> In-Reply-To: <20130404125414.GP23069@rocoto.smurfnet.nu> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig05DBBE3B4C5BBA9E3657DE03" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.48 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2013 17:30:54 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig05DBBE3B4C5BBA9E3657DE03 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04.04.2013 14:54, Leif Lindholm wrote: > On Wed, Apr 03, 2013 at 10:01:59PM +0200, Vladimir '??-coder/phcoder' S= erbinenko wrote: >>> I don't see grub-mkimage currently being fully cross-platform anyway,= >>> so I would (as mentioned in previous email) prefer to postpone any >>> such adjustments until the basic support is in. I have the patches >>> for it, if not entirely up to date. >> >> grub-mkimage is fully cross-platform and is intended to be usable this= >> way. If you see a problem, please tell. >=20 > Well, the straightforward relocations for EM_386 and EM_X86_64 look OK,= > but much of the fiddly IA64 patching that goes on in grub-mkimagexx.c > (add_value_to_slot_* and make_trampoline) does not appear > endianess-safe to me. >=20 Fixed > Since I didn't want to have to duplicate my relocation handling > between kernel and grub-mkimage, I use kern/arm/dl.c for both. >=20 Could you move the common functions to dl_helper.c as in ISA64? > In order to do that in an endianess-safe way, I need to be able to > export target platform information over there, as well as the > host_to_target/target_to_host macros. This would involve moving these > macros, as well as the struct image_target_desc definition, out of > grub-mkimage.c. Is big-endian ARM of any interest at all? I was under impression that it was limited to few devices and not supported by either u-boot or EFI. You still have grub_le_to_cpu / grub_cpu_to_le >=20 > However, this would also make it possible to do the same for IA64, > and get rid of some code duplication between grub-mkimagexx.c and > kern/ia64/dl.c. >=20 I already did. For IA64 I simply used le_to_cpu/cpu_to_le as ia64-efi is always little-endian --------------enig05DBBE3B4C5BBA9E3657DE03 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlFkUEYACgkQNak7dOguQgkInwEAhC1SQ3cZwp+MEJYZXl/qyItw VCttjFvymZjZZzn/oN0A/1+p73KXw3yds4ebqVDqabGLwVqO1RK1R9WzXrpCjEhM =pn+U -----END PGP SIGNATURE----- --------------enig05DBBE3B4C5BBA9E3657DE03--