From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] fix autogen.sh on "dirty" tree
Date: Tue, 16 Apr 2013 16:11:57 +0200 [thread overview]
Message-ID: <516D5C2D.5030807@gmail.com> (raw)
In-Reply-To: <20130410204534.6cb6d43a@opensuse.site>
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]
On 10.04.2013 18:45, Andrey Borzenkov wrote:
> В Tue, 9 Apr 2013 20:20:26 +0400
> Andrey Borzenkov <arvidjaar@gmail.com> пишет:
>
>> for x in mpi-asm-defs.h mpih-add1.c mpih-sub1.c mpih-mul1.c mpih-mul2.c mpih-mul3.c mpih-lshift.c mpih-rshift.c; do
>> - if [ -f grub-core/lib/libgcrypt-grub/mpi/"$x" ]; then
>> + if [ -h grub-core/lib/libgcrypt-grub/mpi/"$x" ]; then
>> rm grub-core/lib/libgcrypt-grub/mpi/"$x"
>> fi
>> ln -s generic/"$x" grub-core/lib/libgcrypt-grub/mpi/"$x"
>
>
> Hmm ... they become plain files in tardist ...
>
> What is better - check for both -f and -h or simply use cp instead of
> ln? cp looks simpler and directory is regenerated from scratch anyway.
>
The idea behind ln is that if compilation fails on a file then when if
you modified the file reported in error your changes will be to definite
file, not to a temporary copy.
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2013-04-16 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 16:20 [PATCH] fix autogen.sh on "dirty" tree Andrey Borzenkov
2013-04-10 16:45 ` Andrey Borzenkov
2013-04-16 14:11 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D5C2D.5030807@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).