From: Francesco Lavra <francescolavra.fl@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>,
"Leif Lindholm" <leif.lindholm@linaro.org>
Subject: Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms
Date: Sat, 11 May 2013 20:00:01 +0200 [thread overview]
Message-ID: <518E8721.2020804@gmail.com> (raw)
In-Reply-To: <20130509180853.GH28516@rocoto.smurfnet.nu>
On 05/09/2013 08:08 PM, Leif Lindholm wrote:
> Attached is a patch that:
> - incoorporates Francesco's bug fixes
> - splits out relocation work into dl_helper.c
> - cleans up code slightly
> - makes relocations use le_to_cpu/cpu_to_le
> - changes all grub_util printout calls to grub_dprintf
[...]
> === modified file 'util/grub-mkimagexx.c'
> --- util/grub-mkimagexx.c 2013-04-12 14:53:58 +0000
> +++ util/grub-mkimagexx.c 2013-05-09 16:34:59 +0000
> @@ -542,7 +542,6 @@
> grub_util_info (" ABS32:\toffset=%d\t(0x%08x)",
> (int) sym_addr, (int) sym_addr);
> /* Data will be naturally aligned */
> - // sym_addr -= offset;
> sym_addr += 0x400;
This 0x400 constant still bothers me a bit :)
--
Francesco
prev parent reply other threads:[~2013-05-11 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 17:01 [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms Leif Lindholm
2013-04-01 2:31 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-01 10:41 ` Francesco Lavra
2013-04-01 11:23 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-01 14:10 ` Francesco Lavra
2013-04-01 14:16 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-01 14:49 ` Francesco Lavra
2013-04-03 17:50 ` Leif Lindholm
2013-04-01 16:24 ` Francesco Lavra
2013-04-03 18:07 ` Leif Lindholm
2013-04-03 20:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-04 12:54 ` Leif Lindholm
2013-04-09 17:30 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-05-09 18:08 ` Leif Lindholm
2013-05-11 8:42 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-05-11 18:00 ` Francesco Lavra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518E8721.2020804@gmail.com \
--to=francescolavra.fl@gmail.com \
--cc=grub-devel@gnu.org \
--cc=leif.lindholm@linaro.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).