From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UbE4O-00065z-OW for mharc-grub-devel@gnu.org; Sat, 11 May 2013 13:58:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbE4K-00065d-J7 for grub-devel@gnu.org; Sat, 11 May 2013 13:58:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbE4I-0004qu-3k for grub-devel@gnu.org; Sat, 11 May 2013 13:58:52 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:35126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbE4H-0004qQ-TZ for grub-devel@gnu.org; Sat, 11 May 2013 13:58:50 -0400 Received: by mail-wi0-f174.google.com with SMTP id m6so1615629wiv.13 for ; Sat, 11 May 2013 10:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=XOopwHB6srn86L6Ys5H+0x8KsXd8zQ3Y+rMM2CkQcDA=; b=K5RbSBmROmoI3y6SB+XUz544c62pariMTt2MFnrn75HdL7UEaEdJjV3S4oT1pRm3DY JppkGBEaiyWT2vWNwDN9Aqn2OVnkGIh2rw/zZnaq04v5Jmx7XUh56+R1QkROIvEWK2pF dEv18tpzM9uktJo8E1SdaFawt81fbXmDfwueZ8KAIOv0AzWtTQvs0xTA87XzzjS6baTY cw+kosAzHw9dEJplthS1rYb9vxzFN7LHHs0NB4Uvowlsd9qXG3KXXWBkkU0yZHdCh/XE +U1fOsqkrYAE63nz/Mn+15Tq1YCrfYpCd8dRlnejmO7Pd1FbzUTZHq7pMkQqlRAsUzAF A6Fw== X-Received: by 10.194.121.200 with SMTP id lm8mr3478087wjb.55.1368295129023; Sat, 11 May 2013 10:58:49 -0700 (PDT) Received: from [192.168.56.2] (adsl-ull-92-98.47-151.net24.it. [151.47.98.92]) by mx.google.com with ESMTPSA id ff10sm5580629wib.10.2013.05.11.10.58.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 11 May 2013 10:58:48 -0700 (PDT) Message-ID: <518E8721.2020804@gmail.com> Date: Sat, 11 May 2013 20:00:01 +0200 From: Francesco Lavra User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms References: <5159B4CB.2040300@gmail.com> <20130403180757.GO23069@rocoto.smurfnet.nu> <515C8AB7.7000602@gmail.com> <20130404125414.GP23069@rocoto.smurfnet.nu> <51645046.6070403@gmail.com> <20130509180853.GH28516@rocoto.smurfnet.nu> In-Reply-To: <20130509180853.GH28516@rocoto.smurfnet.nu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22e Cc: =?UTF-8?B?VmxhZGltaXIgJ8+GLQ==?= =?UTF-8?B?Y29kZXIvcGhjb2RlcicgU2VyYmluZW5rbw==?= , Leif Lindholm X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 May 2013 17:58:55 -0000 On 05/09/2013 08:08 PM, Leif Lindholm wrote: > Attached is a patch that: > - incoorporates Francesco's bug fixes > - splits out relocation work into dl_helper.c > - cleans up code slightly > - makes relocations use le_to_cpu/cpu_to_le > - changes all grub_util printout calls to grub_dprintf [...] > === modified file 'util/grub-mkimagexx.c' > --- util/grub-mkimagexx.c 2013-04-12 14:53:58 +0000 > +++ util/grub-mkimagexx.c 2013-05-09 16:34:59 +0000 > @@ -542,7 +542,6 @@ > grub_util_info (" ABS32:\toffset=%d\t(0x%08x)", > (int) sym_addr, (int) sym_addr); > /* Data will be naturally aligned */ > - // sym_addr -= offset; > sym_addr += 0x400; This 0x400 constant still bothers me a bit :) -- Francesco