From: Francesco Lavra <francescolavra.fl@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 2/2] ls core command: handle listing of the root directory
Date: Sat, 18 May 2013 12:26:17 +0200 [thread overview]
Message-ID: <51975749.6030501@gmail.com> (raw)
In-Reply-To: <518F7544.5020202@gmail.com>
On 05/12/2013 12:56 PM, Francesco Lavra wrote:
> Currently, listing of the root directory of a device with the command:
> ls (device_name)
> requires the underlying filesystem driver to handle an empty path
> string as if it was the root directory path "/". This introduces
> duplicated code across the different filesystem drivers. If a given
> filesystem driver does not implement special handling of the empty
> path string, the above command gives "error: invalid file name `'."
> This error happens for instance with the ext4 filesystem.
> The best place to handle correctly the empty path string and transform
> it in "/" is the function grub_core_cmd_ls(), so that handling from
> each filesystem driver is not required anymore.
After revision 5010, issuing the ls command with a device name as
parameter gives a response such as:
(device_name): Filesystem is <filesystem name>.
But grub.texi says:
"
@deffn Command ls [arg @dots{}]
List devices or files.
With no arguments, print all devices known to GRUB.
If the argument is a device name enclosed in parentheses (@pxref{Device
syntax}), then list all files at the root directory of that device.
If the argument is a directory given as an absolute file name (@pxref{File
name syntax}), then list the contents of that directory.
@end deffn
"
Which is the correct behavior?
next prev parent reply other threads:[~2013-05-18 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 10:53 PATCH [0/2] ls core command: cleanup and fix Francesco Lavra
2013-05-12 10:54 ` [PATCH 1/2] ls core command: remove unreachable code Francesco Lavra
2013-05-12 10:56 ` [PATCH 2/2] ls core command: handle listing of the root directory Francesco Lavra
2013-05-18 10:26 ` Francesco Lavra [this message]
2013-06-02 14:48 ` Francesco Lavra
2013-06-03 5:21 ` Andrey Borzenkov
2013-11-27 18:41 ` Andrey Borzenkov
2013-11-28 6:31 ` Vladimir 'phcoder' Serbinenko
2013-11-28 13:27 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51975749.6030501@gmail.com \
--to=francescolavra.fl@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).