From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Uj9GH-00032G-CO
	for mharc-grub-devel@gnu.org; Sun, 02 Jun 2013 10:27:57 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <francescolavra.fl@gmail.com>) id 1Uj9GD-000322-HR
	for grub-devel@gnu.org; Sun, 02 Jun 2013 10:27:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <francescolavra.fl@gmail.com>) id 1Uj8lu-0007a8-2P
	for grub-devel@gnu.org; Sun, 02 Jun 2013 09:56:40 -0400
Received: from mail-ea0-x22c.google.com ([2a00:1450:4013:c01::22c]:60839)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <francescolavra.fl@gmail.com>) id 1Uj8lt-0007a3-PI
	for grub-devel@gnu.org; Sun, 02 Jun 2013 09:56:33 -0400
Received: by mail-ea0-f172.google.com with SMTP id g14so455625eak.3
	for <grub-devel@gnu.org>; Sun, 02 Jun 2013 06:56:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:subject
	:content-type:content-transfer-encoding;
	bh=n+0EbB5/Vd+gJ8WSuiWbyJTHMNFSbVzI0niwt0k1OJM=;
	b=TmmSgW7qPtjHjdPTPnQUE5zb9rnEUkivufpKqzE77vcVm8rWkaWsfwlqTDSYpKDUlf
	znUIGFZufLDGOb/TZpCs+OHLHsIQD9S1rb0sqRem7RdV3fgPyJIcr2wt9v0TPb9Yh1kc
	1l7F+QaLeoaKCwPdOT0LAqSa0IYH95UMuAuG+1C3MwyQPc5tg2igep4lBNkqNMIzGWFt
	mVztD7c1OgWAupoWvEiX1ehFLQFmVfuFOBuMwPVi12wWW+sj9gCV/DKiSNBpFhOicbg9
	WI172Mb0mZxrgf2azRCeI4y+3alwsqZQcpfcYsAoBJ+g6VuqAfFY48pfJHqNJEbxgZlW
	4I8A==
X-Received: by 10.14.9.136 with SMTP id 8mr19660206eet.37.1370181392201;
	Sun, 02 Jun 2013 06:56:32 -0700 (PDT)
Received: from [192.168.56.2] (adsl-ull-89-138.46-151.net24.it.
	[151.46.138.89])
	by mx.google.com with ESMTPSA id e1sm44262279eem.10.2013.06.02.06.56.30
	for <grub-devel@gnu.org>
	(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Sun, 02 Jun 2013 06:56:31 -0700 (PDT)
Message-ID: <51AB4F17.4000007@gmail.com>
Date: Sun, 02 Jun 2013 15:56:39 +0200
From: Francesco Lavra <francescolavra.fl@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
MIME-Version: 1.0
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: [PATCH] Fix listing of directory contents for root device
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
	(bad octet value).
X-Received-From: 2a00:1450:4013:c01::22c
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Jun 2013 14:27:56 -0000

Since revision 5010, issuing the ls command with a path not including 
the device name results in a NULL pointer dereference. This patch fixes 
the above by reverting one of the three hunks of the patch applied to 
create revision 5010.

Regards,
Francesco

2013-06-02  Francesco Lavra  <francescolavra.fl@gmail.com>

	* grub-core/kern/corecmd.c (grub_core_cmd_ls): Fix handling of paths
	without a device name.

=== modified file 'grub-core/kern/corecmd.c'
--- grub-core/kern/corecmd.c	2013-05-15 08:11:25 +0000
+++ grub-core/kern/corecmd.c	2013-06-02 13:42:53 +0000
@@ -134,7 +134,7 @@
 
       fs = grub_fs_probe (dev);
       path = grub_strchr (argv[0], ')');
-      if (! *path)
+      if (! path)
 	path = argv[0];
       else
 	path++;