Re: [RFC] Support for UEFI ESP in os-prober

[Bruce Dubbs <bruce.dubbs@gmail.com>]

Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 05.06.2013 19:58, Andrey Borzenkov wrote:
>> В Wed, 05 Jun 2013 12:21:54 -0500
>> Bruce Dubbs <bruce.dubbs@gmail.com> пишет:
>>
>>> Mads Kiilerich wrote:
>>>> On 05/31/2013 07:03 PM, Bruce Dubbs wrote:
>>>>> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>>>>
>>>>>> I must say I'm generally disappointed with os-prober and have
>>>>>> ideas to move away from it. I'll start another topic for it.
>>>>>
>>>>> I agree.  I would prefer adding an include command so grub.cfg could
>>>>> just do something like:
>>>>>
>>>>> include /boot/grub/grub.d/*.cfg
>>>>>
>>>>> and have an install procedure drop in one or more menu items instead
>>>>> of every os install or update rewriting the entire grub.cfg every time.
>>>>
>>>> http://www.freedesktop.org/wiki/Specifications/BootLoaderSpec/ describes
>>>> such a configuration structure, and
>>>> http://pkgs.fedoraproject.org/cgit/grub2.git/plain/0362-blscfg-add-blscfg-module-to-parse-Boot-Loader-Specif.patch
>>>> implements it as a grub command.
>>>
>>> Although that's a good start, it seems a little too specific.  What I
>>> had in mind would be the equivalent to the source command in bash.
>>
>> grub already has "source" command.
>>
>>>                                                                     For
>>> example,
>>>
>>> if condition; then
>>>     include (hd0,3)/grub/custom/themes/themeA.cfg
>>> else
>>>     include (hd0,2)/boot/grub/themes/themeB.cfg
>>> fi
>>>
>>> # Get menuentries
>>> include /boot/grub/grub.d/*.cfg
>>>
>>
>> Implementing full-fledged globbing in grub is probably overkill; adding
>> "source_dir" command looks more doable. Something like
>>
> We already have globbing. Trouble with this approach is that ->dir
> method may be slow or (especially on network systems) absent. It should
> not be relied upon unless absolutely necessary.

This reminds me of the phrase "perfect is the enemy of good".  What 
percentage of systems rely on network capabilities for booting?

>> source_dir --suffix .cfg /boot/grub/grub.d