From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UlIap-00005U-KY for mharc-grub-devel@gnu.org; Sat, 08 Jun 2013 08:50:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlIam-0008Vw-Qt for grub-devel@gnu.org; Sat, 08 Jun 2013 08:50:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UlIal-0000Id-Oz for grub-devel@gnu.org; Sat, 08 Jun 2013 08:50:00 -0400 Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]:63264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlIal-0000IY-HD for grub-devel@gnu.org; Sat, 08 Jun 2013 08:49:59 -0400 Received: by mail-ea0-f173.google.com with SMTP id g15so4090663eak.32 for ; Sat, 08 Jun 2013 05:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=NOrTTbVQHRLY5EiCNOkYIoxv+RhISvuih1WE3zeuVfU=; b=quEqyMFbH6mL93GnC2UjVzXRzjTtUUKbk0DOrl5KpjN9/AJpO+IJmnh0lGK9g1CaEw CVPZOrHoBDlbgUuIJE058EOMm3S+r4iF9sAfUy4xSKsYHQlIhwHOAsTSco1247i8izoV O9/drM+h3j0jKhZBsO1JfGSGdZwDpmYw1aZCMlovMKB5l1SARscl1pLhYcAsC0lfd/sk s076qYKF/aWfF1ABkJKoTpRUgOQ8YRTZdz353pupP0krhwPSGO1LZC5bsOQ4VOBJDnEh a0qU7H1mbNZVpdWy0VDTFuJydTPirm2d72EVLf64cNYGfd8IRDi00GaFRARwrqBzMnsO kvzQ== X-Received: by 10.15.99.2 with SMTP id bk2mr3049891eeb.76.1370695798623; Sat, 08 Jun 2013 05:49:58 -0700 (PDT) Received: from ?IPv6:2001:67c:10ec:3e82:8000::1330? ([2001:67c:10ec:3e82:8000::1330]) by mx.google.com with ESMTPSA id y10sm6274321eev.3.2013.06.08.05.49.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 08 Jun 2013 05:49:58 -0700 (PDT) Message-ID: <51B3284D.5070804@gmail.com> Date: Sat, 08 Jun 2013 14:49:17 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130518 Icedove/17.0.5 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] add support for Linux MD linear level References: <1370695210-10289-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1370695210-10289-1-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2XRISQSPVCFHLIRWNOHXS" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jun 2013 12:50:02 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XRISQSPVCFHLIRWNOHXS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08.06.2013 14:40, Andrey Borzenkov wrote: > This appears to be trivial enough and occasionally useful. >=20 > It also fixes level translation for 1.x super which was broken > for multipath level as well. Linear isn't RAID1. You'd need to define a segment for every device. >=20 > Signed-off-by: Andrey Borzenkov >=20 > --- > ChangeLog | 8 ++++++++ > grub-core/disk/mdraid1x_linux.c | 6 +++--- > grub-core/disk/mdraid_linux.c | 4 ++-- > 3 files changed, 13 insertions(+), 5 deletions(-) >=20 > diff --git a/ChangeLog b/ChangeLog > index 4d8f343..e4c1980 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,11 @@ > +2013-06-08 Andrey Borzenkov > + > + * grub-core/disk/mdraid1x_linux.c (grub_mdraid_detect): Support > + linear level by mapping it to RAID1. Pass correct mapped level > + to grub_diskfilter_make_raid. > + * grub-core/disk/mdraid_linux.c (grub_mdraid_detect): Support > + linear level by mapping it to RAID1. > + > 2013-06-07 Andrey Borzenkov > =20 > * grub-core/script/execute.c (grub_script_execute_sourcecode): Split > diff --git a/grub-core/disk/mdraid1x_linux.c b/grub-core/disk/mdraid1x_= linux.c > index a0e65a8..3c18c79 100644 > --- a/grub-core/disk/mdraid1x_linux.c > +++ b/grub-core/disk/mdraid1x_linux.c > @@ -160,8 +160,8 @@ grub_mdraid_detect (grub_disk_t disk, > =20 > level =3D grub_le_to_cpu32 (sb.level); > =20 > - /* Multipath. */ > - if ((int) level =3D=3D -4) > + /* Multipath or linear */ > + if ((int) level =3D=3D -4 || (int) level =3D=3D -1) > level =3D 1; > =20 > if (level !=3D 0 && level !=3D 1 && level !=3D 4 && > @@ -207,7 +207,7 @@ grub_mdraid_detect (grub_disk_t disk, > : grub_le_to_cpu64 (sb.data_size), > grub_le_to_cpu32 (sb.chunksize), > grub_le_to_cpu32 (sb.layout), > - grub_le_to_cpu32 (sb.level)); > + level); > =20 > return array; > } > diff --git a/grub-core/disk/mdraid_linux.c b/grub-core/disk/mdraid_linu= x.c > index f408fd3..4e64d72 100644 > --- a/grub-core/disk/mdraid_linux.c > +++ b/grub-core/disk/mdraid_linux.c > @@ -216,8 +216,8 @@ grub_mdraid_detect (grub_disk_t disk, > /* FIXME: Check the checksum. */ > =20 > level =3D grub_md_to_cpu32 (sb.level); > - /* Multipath. */ > - if ((int) level =3D=3D -4) > + /* Multipath or linear */ > + if ((int) level =3D=3D -4 || (int) level =3D=3D -1) > level =3D 1; > =20 > if (level !=3D 0 && level !=3D 1 && level !=3D 4 && >=20 ------enig2XRISQSPVCFHLIRWNOHXS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlGzKFIACgkQNak7dOguQgnPpgD/UXHtrT7fs1QILq7CY2j+q0+c 6DA2sPHv0Qa/zNeNxMAA/1TUWWySP2m60AtCZU87Mn1rNkPDy1Mi24aXaYqI05nK =D9BJ -----END PGP SIGNATURE----- ------enig2XRISQSPVCFHLIRWNOHXS--