From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [BUG][PATCH] configure.ac: Respect the configured freetype-config
Date: Sat, 15 Jun 2013 21:08:27 +0200 [thread overview]
Message-ID: <51BCBBAB.5040109@gmail.com> (raw)
In-Reply-To: <CAEvUa7k0AAS1ixmMQO3LJsxc6URonf=i0E7s82ByDRqWHJ40UA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]
On 11.06.2013 19:31, David Michael wrote:
> Hi,
>
> A patch with a ChangeLog entry follows. I didn't see very specific
> submission guidelines, so let me know if this message needs to be sent
> in some more rigid format.
>
> Thanks.
Patch is good. Comitting it.
@Andrey: Thanks for handling this.
>
> David
>
>
> === modified file 'ChangeLog'
> --- ChangeLog 2013-06-07 16:36:42 +0000
> +++ ChangeLog 2013-06-11 16:28:03 +0000
> @@ -1,3 +1,8 @@
> +2013-06-11 David Michael <fedora.dm0@gmail.com>
> +
> + * configure.ac (FREETYPE): Change AC_CHECK_PROGS to AC_CHECK_TOOLS.
> + (freetype_cflags,freetype_libs): Change freetype-config to $FREETYPE.
> +
> 2013-06-07 Andrey Borzenkov <arvidjaar@gmail.com>
>
> * grub-core/script/execute.c (grub_script_execute_sourcecode): Split
>
> === modified file 'configure.ac'
> --- configure.ac 2013-06-07 14:02:16 +0000
> +++ configure.ac 2013-06-11 13:54:44 +0000
> @@ -944,7 +944,7 @@
>
> if test x"$grub_mkfont_excuse" = x ; then
> # Check for freetype libraries.
> - AC_CHECK_PROGS([FREETYPE], [freetype-config])
> + AC_CHECK_TOOLS([FREETYPE], [freetype-config])
> if test "x$FREETYPE" = x ; then
> grub_mkfont_excuse=["need freetype2 library"]
> fi
> @@ -952,8 +952,8 @@
>
> if test x"$grub_mkfont_excuse" = x ; then
> # Check for freetype libraries.
> - freetype_cflags=`freetype-config --cflags`
> - freetype_libs=`freetype-config --libs`
> + freetype_cflags=`$FREETYPE --cflags`
> + freetype_libs=`$FREETYPE --libs`
> SAVED_CPPFLAGS="$CPPFLAGS"
> CPPFLAGS="$CPPFLAGS $freetype_cflags"
> AC_CHECK_HEADERS([ft2build.h], [],
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
prev parent reply other threads:[~2013-06-15 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 18:04 [BUG][PATCH] configure.ac: Respect the configured freetype-config David Michael
2013-06-07 18:20 ` Andrey Borzenkov
2013-06-07 18:35 ` David Michael
2013-06-08 4:00 ` Andrey Borzenkov
2013-06-09 21:10 ` Paul Menzel
2013-06-10 21:05 ` David Michael
2013-06-11 14:31 ` David Michael
2013-06-11 14:48 ` Andrey Borzenkov
2013-06-11 15:23 ` David Michael
2013-06-11 15:41 ` Andrey Borzenkov
2013-06-11 17:31 ` David Michael
2013-06-15 19:08 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BCBBAB.5040109@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).