From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] do not hardcode color in gfxterm
Date: Sun, 16 Jun 2013 13:41:24 +0200 [thread overview]
Message-ID: <51BDA464.7090408@gmail.com> (raw)
In-Reply-To: <1371379506-30318-1-git-send-email-arvidjaar@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]
On 16.06.2013 12:45, Andrey Borzenkov wrote:
> gfxterm was using hardcoded color on intialization. So first colors
> were set in normal to white/black and then gfxterm was loaded and set
> colors to light-gray/black.
>
> Make sure gfxterm is using current colors during initialization.
>
Go ahead.
> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
>
> ---
> ChangeLog | 5 +++++
> grub-core/term/gfxterm.c | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index e71a848..33de282 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-06-16 Andrey Borzenkov <arvidjaar@gmail.com>
> +
> + * grub-core/term/gfxterm.c (grub_virtual_screen_setup): Use
> + grub_term_normal_color, do not hardcode GRUB_TERM_DEFAULT_NORMAL_COLOR.
> +
> 2013-06-16 Vladimir Serbinenko <phcoder@gmail.com>
>
> Fix casts when compiling coreboot-specific code for 64-bit EFI.
> diff --git a/grub-core/term/gfxterm.c b/grub-core/term/gfxterm.c
> index b1d0707..7e00678 100644
> --- a/grub-core/term/gfxterm.c
> +++ b/grub-core/term/gfxterm.c
> @@ -249,7 +249,7 @@ grub_virtual_screen_setup (unsigned int x, unsigned int y,
>
> virtual_screen.standard_color_setting = DEFAULT_STANDARD_COLOR;
>
> - virtual_screen.term_color = GRUB_TERM_DEFAULT_NORMAL_COLOR;
> + virtual_screen.term_color = grub_term_normal_color;
>
> set_term_color (virtual_screen.term_color);
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
prev parent reply other threads:[~2013-06-16 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 10:45 [PATCH] do not hardcode color in gfxterm Andrey Borzenkov
2013-06-16 11:41 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BDA464.7090408@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).