[PATCH] do not hardcode color in gfxterm

[PATCH] do not hardcode color in gfxterm

[Andrey Borzenkov]

gfxterm was using hardcoded color on intialization. So first colors
were set in normal to white/black and then gfxterm was loaded and set
colors to light-gray/black.

Make sure gfxterm is using current colors during initialization.

Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>

---
 ChangeLog                | 5 +++++
 grub-core/term/gfxterm.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index e71a848..33de282 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-06-16  Andrey Borzenkov <arvidjaar@gmail.com>
+
+	* grub-core/term/gfxterm.c (grub_virtual_screen_setup): Use
+	grub_term_normal_color, do not hardcode GRUB_TERM_DEFAULT_NORMAL_COLOR.
+
 2013-06-16  Vladimir Serbinenko  <phcoder@gmail.com>
 
 	Fix casts when compiling coreboot-specific code for 64-bit EFI.
diff --git a/grub-core/term/gfxterm.c b/grub-core/term/gfxterm.c
index b1d0707..7e00678 100644
--- a/grub-core/term/gfxterm.c
+++ b/grub-core/term/gfxterm.c
@@ -249,7 +249,7 @@ grub_virtual_screen_setup (unsigned int x, unsigned int y,
 
   virtual_screen.standard_color_setting = DEFAULT_STANDARD_COLOR;
 
-  virtual_screen.term_color = GRUB_TERM_DEFAULT_NORMAL_COLOR;
+  virtual_screen.term_color = grub_term_normal_color;
 
   set_term_color (virtual_screen.term_color);
 
-- 
tg: (0ed37fc..) u/highlight_after_more (depends on: master)

Re: [PATCH] do not hardcode color in gfxterm

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

On 16.06.2013 12:45, Andrey Borzenkov wrote:
> gfxterm was using hardcoded color on intialization. So first colors
> were set in normal to white/black and then gfxterm was loaded and set
> colors to light-gray/black.
> 
> Make sure gfxterm is using current colors during initialization.
> 
Go ahead.
> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
> 
> ---
>  ChangeLog                | 5 +++++
>  grub-core/term/gfxterm.c | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index e71a848..33de282 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-06-16  Andrey Borzenkov <arvidjaar@gmail.com>
> +
> +	* grub-core/term/gfxterm.c (grub_virtual_screen_setup): Use
> +	grub_term_normal_color, do not hardcode GRUB_TERM_DEFAULT_NORMAL_COLOR.
> +
>  2013-06-16  Vladimir Serbinenko  <phcoder@gmail.com>
>  
>  	Fix casts when compiling coreboot-specific code for 64-bit EFI.
> diff --git a/grub-core/term/gfxterm.c b/grub-core/term/gfxterm.c
> index b1d0707..7e00678 100644
> --- a/grub-core/term/gfxterm.c
> +++ b/grub-core/term/gfxterm.c
> @@ -249,7 +249,7 @@ grub_virtual_screen_setup (unsigned int x, unsigned int y,
>  
>    virtual_screen.standard_color_setting = DEFAULT_STANDARD_COLOR;
>  
> -  virtual_screen.term_color = GRUB_TERM_DEFAULT_NORMAL_COLOR;
> +  virtual_screen.term_color = grub_term_normal_color;
>  
>    set_term_color (virtual_screen.term_color);
>  
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]