From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] fix grub-mknetdir --help output
Date: Fri, 12 Jul 2013 15:45:03 +0200 [thread overview]
Message-ID: <51E0085F.7050905@gmail.com> (raw)
In-Reply-To: <1371965450-21417-1-git-send-email-arvidjaar@gmail.com>
Go ahead
On 23.06.2013 07:30, Andrey Borzenkov wrote:
> Remove stray line. It
>
> a) incorrect, because grub-mknetdir does not install grub on hard drive
> b) causes --help to fail immediately due to
>
> Usage: grub-mknetdir [OPTION]
> gettext: missing arguments
>
> It was this way for quite some time, but became obvious only recently
> when all utilities started to use "set -e" by default.
>
> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
>
> ---
> util/grub-mknetdir.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/util/grub-mknetdir.in b/util/grub-mknetdir.in
> index 97d4155..b7b59da 100644
> --- a/util/grub-mknetdir.in
> +++ b/util/grub-mknetdir.in
> @@ -37,7 +37,6 @@ itanium_dir="${libdir}/@PACKAGE@/ia64-efi"
> # Print the usage.
> usage () {
> gettext_printf "Usage: %s [OPTION]\n" "$self"
> - gettext; echo "Install GRUB on your drive."; echo
> echo
> print_option_help "-h, --help" "$(gettext "print this message and exit")"
> grub_print_install_files_help
>
prev parent reply other threads:[~2013-07-12 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 5:30 [PATCH] fix grub-mknetdir --help output Andrey Borzenkov
2013-07-12 13:45 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E0085F.7050905@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).