grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix grub-mknetdir --help output
@ 2013-06-23  5:30 Andrey Borzenkov
  2013-07-12 13:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Borzenkov @ 2013-06-23  5:30 UTC (permalink / raw)
  To: grub-devel

Remove stray line. It

a) incorrect, because grub-mknetdir does not install grub on hard drive
b) causes --help to fail immediately due to

Usage: grub-mknetdir [OPTION]
gettext: missing arguments

It was this way for quite some time, but became obvious only recently
when all utilities started to use "set -e" by default.

Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>

---
 util/grub-mknetdir.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/util/grub-mknetdir.in b/util/grub-mknetdir.in
index 97d4155..b7b59da 100644
--- a/util/grub-mknetdir.in
+++ b/util/grub-mknetdir.in
@@ -37,7 +37,6 @@ itanium_dir="${libdir}/@PACKAGE@/ia64-efi"
 # Print the usage.
 usage () {
     gettext_printf "Usage: %s [OPTION]\n" "$self"
-    gettext; echo "Install GRUB on your drive."; echo
     echo
     print_option_help "-h, --help" "$(gettext "print this message and exit")"
     grub_print_install_files_help
-- 
tg: (2cca311..) u/grub-mknetdir-gettext (depends on: master)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix grub-mknetdir --help output
  2013-06-23  5:30 [PATCH] fix grub-mknetdir --help output Andrey Borzenkov
@ 2013-07-12 13:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 0 replies; 2+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2013-07-12 13:45 UTC (permalink / raw)
  To: The development of GNU GRUB

Go ahead
On 23.06.2013 07:30, Andrey Borzenkov wrote:
> Remove stray line. It
>
> a) incorrect, because grub-mknetdir does not install grub on hard drive
> b) causes --help to fail immediately due to
>
> Usage: grub-mknetdir [OPTION]
> gettext: missing arguments
>
> It was this way for quite some time, but became obvious only recently
> when all utilities started to use "set -e" by default.
>
> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
>
> ---
>   util/grub-mknetdir.in | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/util/grub-mknetdir.in b/util/grub-mknetdir.in
> index 97d4155..b7b59da 100644
> --- a/util/grub-mknetdir.in
> +++ b/util/grub-mknetdir.in
> @@ -37,7 +37,6 @@ itanium_dir="${libdir}/@PACKAGE@/ia64-efi"
>   # Print the usage.
>   usage () {
>       gettext_printf "Usage: %s [OPTION]\n" "$self"
> -    gettext; echo "Install GRUB on your drive."; echo
>       echo
>       print_option_help "-h, --help" "$(gettext "print this message and exit")"
>       grub_print_install_files_help
>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-12 13:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-23  5:30 [PATCH] fix grub-mknetdir --help output Andrey Borzenkov
2013-07-12 13:45 ` Vladimir 'φ-coder/phcoder' Serbinenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).