From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Uxdep-00015V-7P for mharc-grub-devel@gnu.org; Fri, 12 Jul 2013 09:45:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxden-00013o-AG for grub-devel@gnu.org; Fri, 12 Jul 2013 09:45:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uxdem-0007Rx-6V for grub-devel@gnu.org; Fri, 12 Jul 2013 09:45:09 -0400 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:52752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxdem-0007RU-11 for grub-devel@gnu.org; Fri, 12 Jul 2013 09:45:08 -0400 Received: by mail-wg0-f41.google.com with SMTP id y10so635277wgg.2 for ; Fri, 12 Jul 2013 06:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=SRuUpviw0EvGypO+upvq2nFjdWtsdNUGJJdeHAuEGEg=; b=TfCBOCygfQRkVdXUCPss2Rrr59kn8Qvy8cINR0spFnyZb1a8zKonPcZIZWnrOQqrk8 wuYGyqWGzZMyo5y9R7HVw0wy62j7koDvb9xWQskyHjWM5aPS4P2k3SCmw/tOFukrLpPT 6LffmwNKEle8RTrJYTY8uY2VkzsOno405z7+k10Rz9AS1G2mWVb9DHnlNoASjYb+4p9y 9y67XE/ji2GzTB+8rebvBh+wrDt108J67awb3/njDpp50irhcNaUSx5ONwYUOwnh1sKD f5zxCQJv65Ee1wBsp/u2XBnlxYq/OZHE7QKRLTgLx+YS1spx/mvRZb0f1sJvRwq5x9ae 4rJg== X-Received: by 10.180.83.68 with SMTP id o4mr1800887wiy.5.1373636707303; Fri, 12 Jul 2013 06:45:07 -0700 (PDT) Received: from [192.168.42.68] (117-236.197-178.cust.bluewin.ch. [178.197.236.117]) by mx.google.com with ESMTPSA id b14sm3527448wic.8.2013.07.12.06.45.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 12 Jul 2013 06:45:06 -0700 (PDT) Message-ID: <51E0085F.7050905@gmail.com> Date: Fri, 12 Jul 2013 15:45:03 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] fix grub-mknetdir --help output References: <1371965450-21417-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1371965450-21417-1-git-send-email-arvidjaar@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::229 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jul 2013 13:45:10 -0000 Go ahead On 23.06.2013 07:30, Andrey Borzenkov wrote: > Remove stray line. It > > a) incorrect, because grub-mknetdir does not install grub on hard drive > b) causes --help to fail immediately due to > > Usage: grub-mknetdir [OPTION] > gettext: missing arguments > > It was this way for quite some time, but became obvious only recently > when all utilities started to use "set -e" by default. > > Signed-off-by: Andrey Borzenkov > > --- > util/grub-mknetdir.in | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/grub-mknetdir.in b/util/grub-mknetdir.in > index 97d4155..b7b59da 100644 > --- a/util/grub-mknetdir.in > +++ b/util/grub-mknetdir.in > @@ -37,7 +37,6 @@ itanium_dir="${libdir}/@PACKAGE@/ia64-efi" > # Print the usage. > usage () { > gettext_printf "Usage: %s [OPTION]\n" "$self" > - gettext; echo "Install GRUB on your drive."; echo > echo > print_option_help "-h, --help" "$(gettext "print this message and exit")" > grub_print_install_files_help >