From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UyKfb-0001bl-7r for mharc-grub-devel@gnu.org; Sun, 14 Jul 2013 07:40:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyKfY-0001YZ-HY for grub-devel@gnu.org; Sun, 14 Jul 2013 07:40:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyKfX-0003Fn-8w for grub-devel@gnu.org; Sun, 14 Jul 2013 07:40:48 -0400 Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:36331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyKfW-0003Fc-Ta for grub-devel@gnu.org; Sun, 14 Jul 2013 07:40:47 -0400 Received: by mail-ee0-f52.google.com with SMTP id c50so7191356eek.11 for ; Sun, 14 Jul 2013 04:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=+RTpuDg1oraOUmZPVyVVTe8BACttVf85fJRLqg/urlY=; b=JJ80a7NIEUJxZTZb7PoE7dxyRpv1WDfkvegntRaszRST5zskVTwl3uzKBxu52QFWEA NVCc3fpGvFS9/pVvVN3Q4pfsTJXmGgoLTO9gPlcYgvwUBEt8Vsn9ggi1b5QNdo4yFqPM AnA+0/0MWv/JjRoChhIgOOYWnf2JC2gSyTAGYmTVNtaQdtKgCJkiqn0PjH1kWzjZDZFR J+5t8Gs5ymFqup2l3hI+k7hEctQOumMfBBLHOY5HzI9VvSy4h70ZJgy/2CIK0HtoyFju PyOFUaRVAYIYOys3vqnuLThU9ZW/Rm9e9lKQ0XjTj3YhppNEnzZeevK3r3sXS46Jl9tR 6SFA== X-Received: by 10.14.193.199 with SMTP id k47mr54671409een.83.1373802046145; Sun, 14 Jul 2013 04:40:46 -0700 (PDT) Received: from [192.168.42.127] (31-236.197-178.cust.bluewin.ch. [178.197.236.31]) by mx.google.com with ESMTPSA id b3sm94104712eev.10.2013.07.14.04.40.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 14 Jul 2013 04:40:45 -0700 (PDT) Message-ID: <51E28E3C.40109@gmail.com> Date: Sun, 14 Jul 2013 13:40:44 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] export net_* variables by default References: <1372016690-24114-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1372016690-24114-1-git-send-email-arvidjaar@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jul 2013 11:40:50 -0000 Go ahead. On 23.06.2013 21:44, Andrey Borzenkov wrote: > All those variables reflect physical interface properties, so they are > global by nature. Export them by default. > > Signed-off-by: Andrey Borzenkov > > --- > grub-core/net/bootp.c | 6 +++++- > grub-core/net/net.c | 6 ++++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/grub-core/net/bootp.c b/grub-core/net/bootp.c > index e0ab47e..72edc21 100644 > --- a/grub-core/net/bootp.c > +++ b/grub-core/net/bootp.c > @@ -49,6 +49,7 @@ set_env_limn_ro (const char *intername, const char *suffix, > grub_env_set (varname, value); > value[len] = c; > grub_register_variable_hook (varname, 0, grub_env_write_readonly); > + grub_env_export (varname); > } > > static void > @@ -212,7 +213,10 @@ grub_net_configure_by_dhcp_ack (const char *name, > } > > if (is_def) > - grub_env_set ("net_default_interface", name); > + { > + grub_env_set ("net_default_interface", name); > + grub_env_export ("net_default_interface"); > + } > > if (device && !*device && bp->server_ip) > { > diff --git a/grub-core/net/net.c b/grub-core/net/net.c > index 5d2c2f0..4810319 100644 > --- a/grub-core/net/net.c > +++ b/grub-core/net/net.c > @@ -891,6 +891,7 @@ grub_net_network_level_interface_register (struct grub_net_network_level_interfa > *ptr = '_'; > grub_env_set (name, buf); > grub_register_variable_hook (name, 0, hwaddr_set_env); > + grub_env_export (name); > } > > { > @@ -904,6 +905,7 @@ grub_net_network_level_interface_register (struct grub_net_network_level_interfa > *ptr = '_'; > grub_env_set (name, buf); > grub_register_variable_hook (name, 0, addr_set_env); > + grub_env_export (name); > } > > inter->card->num_ifaces++; > @@ -1643,12 +1645,16 @@ GRUB_MOD_INIT(net) > { > grub_register_variable_hook ("net_default_server", defserver_get_env, > defserver_set_env); > + grub_env_export ("net_default_server"); > grub_register_variable_hook ("pxe_default_server", defserver_get_env, > defserver_set_env); > + grub_env_export ("pxe_default_server"); > grub_register_variable_hook ("net_default_ip", defip_get_env, > defip_set_env); > + grub_env_export ("net_default_ip"); > grub_register_variable_hook ("net_default_mac", defmac_get_env, > defmac_set_env); > + grub_env_export ("net_default_mac"); > > cmd_addaddr = grub_register_command ("net_add_addr", grub_cmd_addaddr, > /* TRANSLATORS: HWADDRESS stands for >