From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] enable emuusb and emupci on emu platform only
Date: Thu, 25 Jul 2013 16:44:08 +0200 [thread overview]
Message-ID: <51F139B8.7000500@gmail.com> (raw)
In-Reply-To: <1374389627-26694-1-git-send-email-arvidjaar@gmail.com>
On 21.07.2013 08:53, Andrey Borzenkov wrote:
> Is there any reason we may want to build them when not building
> --with-platform=emu?
>
I think it's better to reset COND_EMU_PCI/COND_EMU_USB to false in
configure state when not compiling for emu as usage of both enable and
consition simultaneously is marginal and it's beter not to rely on it
(so to i.a. permit its removal if necessary)
> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
>
> ---
> grub-core/Makefile.core.def | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
> index 06617d7..230bed5 100644
> --- a/grub-core/Makefile.core.def
> +++ b/grub-core/Makefile.core.def
> @@ -477,6 +477,7 @@ module = {
> module = {
> name = emuusb;
> common = bus/usb/usb.c;
> + enable = emu;
> condition = COND_GRUB_EMU_USB;
> };
>
> @@ -546,6 +547,7 @@ module = {
> common = bus/emu/pci.c;
> common = commands/lspci.c;
>
> + enable = emu;
> condition = COND_GRUB_EMU_PCI;
> };
>
>
next prev parent reply other threads:[~2013-07-25 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 6:53 [PATCH] enable emuusb and emupci on emu platform only Andrey Borzenkov
2013-07-25 14:44 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-07-25 17:06 ` Andrey Borzenkov
2013-11-04 3:43 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F139B8.7000500@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).