From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V2Mm5-0005h3-JY for mharc-grub-devel@gnu.org; Thu, 25 Jul 2013 10:44:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2Mm1-0005cC-P7 for grub-devel@gnu.org; Thu, 25 Jul 2013 10:44:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2Mm0-0006YC-Lk for grub-devel@gnu.org; Thu, 25 Jul 2013 10:44:09 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:34366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2Mm0-0006X3-FE for grub-devel@gnu.org; Thu, 25 Jul 2013 10:44:08 -0400 Received: by mail-wi0-f175.google.com with SMTP id m6so5713969wiv.14 for ; Thu, 25 Jul 2013 07:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=tAqLvNMr+UYsWwBHwpatvPOO9iU1I7iORF0LLmxTE5s=; b=mAPgj9ehMgY7a0Jr4yZfNFyU/FKqqwaRqpgbKZMcoheGtjEn7olYBCJCT6zXlBcG9s 4RBgvLOZw0lJXlwbWHH7kUGvhaleq1HauFzWTHeDZ5iDwJCJSjV3+/BqinvdfbJULWL6 05+TflWR7UI//JBawJlwrwgsyxlH9WRYA2PtA5kw1xrCC7SJnWMQIcX+7nb9dwIUDc6a hEMpLs77iZnQ3JhlDxKXAD69qANyRRUbL2R6Yu1zDMPvAP5QixNBEuse2OzCnXb+1aUh o1EOlbB/CaGiALZO85L8+PFgvxQQPVs6SHjRpBEUifAIVLI9Sdk22XMUZFaG9APaYTz1 63JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=tAqLvNMr+UYsWwBHwpatvPOO9iU1I7iORF0LLmxTE5s=; b=jqMoAYFLes39UaAPgsxqsHsNIrLwHmV7asTGkUtHkIwE4LUqpl8d1c7FnjiHXEgT4S vK6KaHfT06mPQm5sB8rYWfcIRuCAhIYMZCASm03V5Wpp5qGB/ntrdKtHeT7iDdzvSky0 ipgRaxKG0FDuUZgD4aTvPcu16hk/skb+e6NkSrk2fiwkM2Sf2FvP0TywZ0D14eY6T9bN gfDnck184UNbRgR9MPYwV/yXs12auQmU/fRbibMs4v8144J1VGeOSRsfYRPFN5fHdHnn DKb/i1xk58Gu+VyRt2+PJ7KuDisM7AMW6YysVOBYW7RxYrDJ/dh+ie/Ho4Bw4+gcg0WZ 61Ew== X-Received: by 10.180.82.196 with SMTP id k4mr2457061wiy.0.1374763447748; Thu, 25 Jul 2013 07:44:07 -0700 (PDT) Received: from [192.168.1.113] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id n7sm4230382wib.1.2013.07.25.07.44.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Jul 2013 07:44:07 -0700 (PDT) Message-ID: <51F139B8.7000500@gmail.com> Date: Thu, 25 Jul 2013 16:44:08 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] enable emuusb and emupci on emu platform only References: <1374389627-26694-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1374389627-26694-1-git-send-email-arvidjaar@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22f X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2013 14:44:11 -0000 On 21.07.2013 08:53, Andrey Borzenkov wrote: > Is there any reason we may want to build them when not building > --with-platform=emu? > I think it's better to reset COND_EMU_PCI/COND_EMU_USB to false in configure state when not compiling for emu as usage of both enable and consition simultaneously is marginal and it's beter not to rely on it (so to i.a. permit its removal if necessary) > Signed-off-by: Andrey Borzenkov > > --- > grub-core/Makefile.core.def | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > index 06617d7..230bed5 100644 > --- a/grub-core/Makefile.core.def > +++ b/grub-core/Makefile.core.def > @@ -477,6 +477,7 @@ module = { > module = { > name = emuusb; > common = bus/usb/usb.c; > + enable = emu; > condition = COND_GRUB_EMU_USB; > }; > > @@ -546,6 +547,7 @@ module = { > common = bus/emu/pci.c; > common = commands/lspci.c; > > + enable = emu; > condition = COND_GRUB_EMU_PCI; > }; > >