From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V2T1E-0001Xb-21 for mharc-grub-devel@gnu.org; Thu, 25 Jul 2013 17:24:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2T16-0001V4-SY for grub-devel@gnu.org; Thu, 25 Jul 2013 17:24:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2T13-0002T4-VF for grub-devel@gnu.org; Thu, 25 Jul 2013 17:24:08 -0400 Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:34623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2T13-0002Sq-N1 for grub-devel@gnu.org; Thu, 25 Jul 2013 17:24:05 -0400 Received: by mail-wg0-f47.google.com with SMTP id j13so2160646wgh.14 for ; Thu, 25 Jul 2013 14:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=JrhYYUAs4HEl62p4OzqvpiafSejCBcsh0+FQYHNhr1Y=; b=g/FPNYYx7ZC0q3SGEcfKHnKDJCaxNIl3UK7Ennsq9r3VMvBNUufIOOV38C8BLkccu4 OfPS1isky/PNhcTir7iEthhvMTK5KsZJfj852kuSGeAhK2tGT1VKfN17hGExBwNXJk5G FStWMV8cT7MTPIAoUMJ5Xu7z1CNum2zZokZnPmowLJ371gaRKBcZP2WpCAU0bzLGOV7X GZU9X7NnBjSUOyDCLZzJcBFLSZL5m4vzTWvdOZqjh/wUmrDooncG6NKkrY3oyodaOpcj EJDOXDXpBbPIee5SiP6JenjRiUNNdzQXJLK8h/dAlQ2Wc2M+1q7jzHdRFF2M65RhXlyH fHrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=JrhYYUAs4HEl62p4OzqvpiafSejCBcsh0+FQYHNhr1Y=; b=YyA3M0qMXOyq57IfLOYygyqOfhpfCRj8ZW5PpcZOMwdQJBjv0WLgLXL+7ViEn/hiPJ NZQxaLYvUby0qL8bW1JTNLoOFmaMIceLD84eaqX3qYCH5yAvKQv37sBdXyQKsy2DkMTd kMfqe4ZvPZ8aKPO650fYFvClOsvKoWL3IHwshvpDc1Ly9WzksA3AYTCZxEZbrGpZWNBT Z5i9N7TgBlMtTAKUEXF8syspjTBWd5QBbtKBmxsd0r5C9aH5bbCXJQb/tIKu9wG8Iwoo ZVo181Ed9ddbCtZOYH6PfBfS+LeqV0dZ4lsLKeQneEGSIzbiPgkQNtSEInENbiqhwKq1 zxTg== X-Received: by 10.180.36.74 with SMTP id o10mr3454774wij.23.1374787444902; Thu, 25 Jul 2013 14:24:04 -0700 (PDT) Received: from [192.168.1.113] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id i1sm606499wiz.6.2013.07.25.14.24.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Jul 2013 14:24:04 -0700 (PDT) Message-ID: <51F19775.5060305@gmail.com> Date: Thu, 25 Jul 2013 23:24:05 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen References: <20130715180006.GA2433@phenom.dumpdata.com> In-Reply-To: <20130715180006.GA2433@phenom.dumpdata.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22f X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2013 21:24:13 -0000 On 15.07.2013 20:00, Konrad Rzeszutek Wilk wrote: > Hey, > > There is a discussion on the linux-kernel mailing list in which the > Linus states that "if you depend on any config file, you're broken > by definition" (https://lkml.org/lkml/2013/7/15/368). > The world is broken by definition sometimes you just can't avoid being broken unless a good facility for your needs is supplied. In this case it would be a documentation on how to detect dom0 pv_ops. We could ship a detector as a GRUB tool if appropriate documentation is provided. > The 20_linux_xen does that however it should not do it. In all fairness > this check is a bit of old as pretty much any upstream kernel > is being built by default from distros to boot with Xen. If it does > not, Xen will print a message telling the user that Linux does not > have the required components. > It depends on kernel config. Not everybody uses one-size-fits-all major distro kernels (no offense for distros but sometimes you need or prefer customized kernels). What happens if one tries to load a kernel without pv_ops on top of xen? Does he at least get a decent error message or just black screen? Some distros increase xen_linux priority above those of standard linux and it may happen that xen is inadvertently installed but no pv_ops kernel is available. With proposed change such setup becomes needlessly unbootable. > This patch removes said check. > > Signed-off-by: Konrad Rzeszutek Wilk > > === modified file 'util/grub.d/20_linux_xen.in' > --- util/grub.d/20_linux_xen.in 2013-03-24 13:03:33 +0000 > +++ util/grub.d/20_linux_xen.in 2013-07-15 17:34:32 +0000 > @@ -144,20 +144,8 @@ > } > > linux_list=`for i in /boot/vmlinu[xz]-* /vmlinu[xz]-* /boot/kernel-*; do > - if grub_file_is_not_garbage "$i"; then > - basename=$(basename $i) > - version=$(echo $basename | sed -e "s,^[^0-9]*-,,g") > - dirname=$(dirname $i) > - config= > - for j in "${dirname}/config-${version}" "${dirname}/config-${alt_version}" "/etc/kernels/kernel-config-${version}" ; do > - if test -e "${j}" ; then > - config="${j}" > - break > - fi > - done > - if (grep -qx "CONFIG_XEN_DOM0=y" "${config}" 2> /dev/null || grep -qx "CONFIG_XEN_PRIVILEGED_GUEST=y" "${config}" 2> /dev/null); then echo -n "$i " ; fi > - fi > - done` > + if grub_file_is_not_garbage "$i"; then echo -n "$i "; fi > + done` > if [ "x${linux_list}" = "x" ] ; then > exit 0 > fi > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >