From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: ctrl-x / ctrl-c may not work under GRUB2 with EFI
Date: Mon, 12 Aug 2013 12:02:24 +0200 [thread overview]
Message-ID: <5208B2B0.8050206@gmail.com> (raw)
In-Reply-To: <5200B552.4020705@wp.pl>
On 06.08.2013 10:35, Pawel Wojtalczyk wrote:
> +#if defined (__i386__) || defined (__x86_64__)
> + if (key.unicode_char < 0x20 && key.unicode_char != 0 &&
> key.unicode_char != '\t' && key.unicode_char != '\b' && key.unicode_char
> != '\n' && key.unicode_char != '\r')
> + return GRUB_TERM_CTRL | (key.unicode_char - 1 + 'a');
> + else
> +#endif /* defined (__i386__) || defined (__x86_64__) */
> + return key.unicode_char;
> else if (key.scan_code < ARRAY_SIZE (efi_codes))
This results in an ambigous else which should be avoided. Also I see no
reason to restrict this to x86 as other platforms are likely to have the
same bug. Also it requires a comment as to why this workaround is
necessarry. Please supply a ChangeLog entry.
prev parent reply other threads:[~2013-08-12 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 8:35 ctrl-x / ctrl-c may not work under GRUB2 with EFI Pawel Wojtalczyk
2013-08-06 16:32 ` Andrey Borzenkov
2013-08-07 3:17 ` Pawel Wojtalczyk
2013-08-12 10:02 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5208B2B0.8050206@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).