From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V8oxP-00067M-Jf for mharc-grub-devel@gnu.org; Mon, 12 Aug 2013 06:02:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8oxM-00066S-QD for grub-devel@gnu.org; Mon, 12 Aug 2013 06:02:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8oxL-0002rY-Ke for grub-devel@gnu.org; Mon, 12 Aug 2013 06:02:32 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:44538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8oxL-0002rO-EX for grub-devel@gnu.org; Mon, 12 Aug 2013 06:02:31 -0400 Received: by mail-we0-f176.google.com with SMTP id q56so5281902wes.35 for ; Mon, 12 Aug 2013 03:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=qLUIUnZXO9r2DWAnO/k4q+te9rhGn2x16Wy/WwFgmso=; b=cif8dCM7TTYA6/CRPnkPOvIo/wagZF6FsVTneBlclrXWK1GEl7eXyrlCJrE0ZBMGp/ fEfdUVrAdGTts5EAUN04Grxe2lzBeW8DBl1HdcxymF2Kj51R5bMHYQK90wXP58scA9Kc YXab4iC5HDWmezTyOAF+2wI5dLjxTH2B42TAsZLCLDiB+cGCkYOhVqvFzKM88lVr9u+O X/AFbxlQx4BKEeGnXU9A7mvlorC1MCNTBAeqvg5qxzwy/AH6e8vPcjLkjVqDP3qyXYwU jkJtmyrZE+hiXuIdd28oa/u8Ryc+xPSYhYqhdpRg77u+vkSD9gHgpAg8OeMS9+V/27ge ELnA== X-Received: by 10.194.179.98 with SMTP id df2mr10721011wjc.49.1376301750709; Mon, 12 Aug 2013 03:02:30 -0700 (PDT) Received: from ?IPv6:2001:67c:10ec:3f42:8000::1340? ([2001:67c:10ec:3f42:8000::1340]) by mx.google.com with ESMTPSA id jf2sm15289407wic.2.2013.08.12.03.02.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 12 Aug 2013 03:02:30 -0700 (PDT) Message-ID: <5208B2B0.8050206@gmail.com> Date: Mon, 12 Aug 2013 12:02:24 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: ctrl-x / ctrl-c may not work under GRUB2 with EFI References: <5200B552.4020705@wp.pl> In-Reply-To: <5200B552.4020705@wp.pl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2013 10:02:34 -0000 On 06.08.2013 10:35, Pawel Wojtalczyk wrote: > +#if defined (__i386__) || defined (__x86_64__) > + if (key.unicode_char < 0x20 && key.unicode_char != 0 && > key.unicode_char != '\t' && key.unicode_char != '\b' && key.unicode_char > != '\n' && key.unicode_char != '\r') > + return GRUB_TERM_CTRL | (key.unicode_char - 1 + 'a'); > + else > +#endif /* defined (__i386__) || defined (__x86_64__) */ > + return key.unicode_char; > else if (key.scan_code < ARRAY_SIZE (efi_codes)) This results in an ambigous else which should be avoided. Also I see no reason to restrict this to x86 as other platforms are likely to have the same bug. Also it requires a comment as to why this workaround is necessarry. Please supply a ChangeLog entry.