From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] remove unused attribute from grub_biosdisk_iterate pull argument
Date: Wed, 14 Aug 2013 10:57:42 +0200 [thread overview]
Message-ID: <520B4686.6090007@gmail.com> (raw)
In-Reply-To: <1375618750-16210-1-git-send-email-arvidjaar@gmail.com>
On 04.08.2013 14:19, Andrey Borzenkov wrote:
> It is not unused anymore.
>
Go ahead
> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
>
> ---
> grub-core/disk/i386/pc/biosdisk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/disk/i386/pc/biosdisk.c b/grub-core/disk/i386/pc/biosdisk.c
> index 7c8dca3..5e6d060 100644
> --- a/grub-core/disk/i386/pc/biosdisk.c
> +++ b/grub-core/disk/i386/pc/biosdisk.c
> @@ -287,7 +287,7 @@ grub_biosdisk_call_hook (grub_disk_dev_iterate_hook_t hook, void *hook_data,
>
> static int
> grub_biosdisk_iterate (grub_disk_dev_iterate_hook_t hook, void *hook_data,
> - grub_disk_pull_t pull __attribute__ ((unused)))
> + grub_disk_pull_t pull)
> {
> int num_floppies;
> int drive;
>
prev parent reply other threads:[~2013-08-14 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 12:19 [PATCH] remove unused attribute from grub_biosdisk_iterate pull argument Andrey Borzenkov
2013-08-14 8:57 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520B4686.6090007@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).