From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V9WuJ-00050K-Gb for mharc-grub-devel@gnu.org; Wed, 14 Aug 2013 04:58:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9Wu9-0004zK-Ml for grub-devel@gnu.org; Wed, 14 Aug 2013 04:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9Wtx-0006pI-Vv for grub-devel@gnu.org; Wed, 14 Aug 2013 04:58:09 -0400 Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:35193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9Wtx-0006p2-PV for grub-devel@gnu.org; Wed, 14 Aug 2013 04:57:57 -0400 Received: by mail-ee0-f49.google.com with SMTP id d41so4694344eek.22 for ; Wed, 14 Aug 2013 01:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=712aummTYOG7NDn5j1ODsPAjYRRetDS2UjaQWgms5Yo=; b=km13N66sHrntearj4S2gOxS+tDMk/Ed0PPeu5iGpebGythFemx3KfCUuja6oK2Okw6 63LH2Vf8dK0ALcmWLqhnXXueofvYXlBbibfyhxKKancJvdSD8wMdBHMOkVrJP7bX4utZ rGwfs3BlOOhI6ZCgI6D7C+le6YSEkqzFPIF0+LN39DXIGv3l8BJM7XbD6Iuk4w3uOsn7 R9IGqIORhPvwkPpc3IxgQ38ZHNO2k+SU31rqWHIgh8QKkKaY1Axd/Q96gcQ1+6nCwUyz dvAmtomb/Jnw6oq9CUdkAtYCaoPMeV3vC9oRXHjV1ZDx2xqgniNyIVcX24P2M72vxi5y og6w== X-Received: by 10.15.91.3 with SMTP id r3mr13558968eez.4.1376470676194; Wed, 14 Aug 2013 01:57:56 -0700 (PDT) Received: from [192.168.42.216] (51-227.197-178.cust.bluewin.ch. [178.197.227.51]) by mx.google.com with ESMTPSA id k7sm73354613eeg.13.2013.08.14.01.57.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 14 Aug 2013 01:57:55 -0700 (PDT) Message-ID: <520B4686.6090007@gmail.com> Date: Wed, 14 Aug 2013 10:57:42 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] remove unused attribute from grub_biosdisk_iterate pull argument References: <1375618750-16210-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1375618750-16210-1-git-send-email-arvidjaar@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 08:58:18 -0000 On 04.08.2013 14:19, Andrey Borzenkov wrote: > It is not unused anymore. > Go ahead > Signed-off-by: Andrey Borzenkov > > --- > grub-core/disk/i386/pc/biosdisk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/grub-core/disk/i386/pc/biosdisk.c b/grub-core/disk/i386/pc/biosdisk.c > index 7c8dca3..5e6d060 100644 > --- a/grub-core/disk/i386/pc/biosdisk.c > +++ b/grub-core/disk/i386/pc/biosdisk.c > @@ -287,7 +287,7 @@ grub_biosdisk_call_hook (grub_disk_dev_iterate_hook_t hook, void *hook_data, > > static int > grub_biosdisk_iterate (grub_disk_dev_iterate_hook_t hook, void *hook_data, > - grub_disk_pull_t pull __attribute__ ((unused))) > + grub_disk_pull_t pull) > { > int num_floppies; > int drive; >