From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VMFv7-0000Dc-C5 for mharc-grub-devel@gnu.org; Wed, 18 Sep 2013 07:27:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMFv4-0000D2-6s for grub-devel@gnu.org; Wed, 18 Sep 2013 07:27:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMFv2-0005Lm-U0 for grub-devel@gnu.org; Wed, 18 Sep 2013 07:27:42 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:58195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMFv2-0005Lf-N2 for grub-devel@gnu.org; Wed, 18 Sep 2013 07:27:40 -0400 Received: by mail-wg0-f48.google.com with SMTP id n12so6190743wgh.3 for ; Wed, 18 Sep 2013 04:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=zFkIB1Kwx6mt+NmXsTLASygt4q8Km7qDA7DevU8Uygg=; b=AXXMMRo2wWpsn4BsDwhPZbtsSMZv81Eco6svneitgNyzmtiCbe1NLjN7Nz651+1FAa L7iuMdVM0mWgQrd9Xb5pva1d420UdSI14MuRfxFKQ5GEkzaTYi/Ou4QYpf5u3pRo0FyL aGVTP3JJli5ZE1YR0NauCFTXKtAWXvreb9t1DOnnb3UVkBYsU0PnpIKQ9Edzc1nDG3NH y0sUxgWFobgmHRsHkP5isHWLc/ztgjRPGLqbdn9PkBVr3ySQprXWFe7coKZWeKVzvEab MHpUkjml9lKY/XvE4smrSWO5DqfuvFw0U0y5u3e0VuX8ZPbIqh4cd8NOhl03euIj/hsE /PPQ== X-Received: by 10.194.80.39 with SMTP id o7mr11559163wjx.39.1379503659929; Wed, 18 Sep 2013 04:27:39 -0700 (PDT) Received: from ?IPv6:2001:67c:10ec:3ec2:8000::1c14? ([2001:67c:10ec:3ec2:8000::1c14]) by mx.google.com with ESMTPSA id mb7sm1793569wic.10.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 18 Sep 2013 04:27:38 -0700 (PDT) Message-ID: <52398E29.30104@gmail.com> Date: Wed, 18 Sep 2013 13:27:37 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130821 Icedove/17.0.8 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Fix invalid USB descriptor endless loop. References: In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2LBSPVNLWPHTRQCRDDSWN" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2013 11:27:43 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2LBSPVNLWPHTRQCRDDSWN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Committed, thanks. On 09.09.2013 08:22, Melki Christian (consultant) wrote: > Hi, >=20 > I discovered that on some PC's the USB stack would produce an invalid d= escriptor upon query without an error. > I don't know why this is the case, maybe broken hardware but I seriousl= y doubt it. > GRUB doesn't handle TT's at all, Clearing TT's or resetting them. Maybe= thats a case for stuck transactions? > The descriptor would contain 0 in length, or atleast the code would thi= nk that offset was the length > and cause an endless loop. > Maybe this type of parsing is completely avoidable but for now I just a= dded a break condition. > GRUB should not hang on faulty devices. >=20 > BR, > Christian >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2LBSPVNLWPHTRQCRDDSWN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlI5jikACgkQNak7dOguQgkWTAD6A7399ZEzRJR7paXWidzGMdS6 +goS0sw7gN+GBYaV45cA/RwtQV8nnUxiB/rE6mIhupHNnRiUmWGDabmOdt8QnpO1 =re64 -----END PGP SIGNATURE----- ------enig2LBSPVNLWPHTRQCRDDSWN--