From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH v3 3/3] Add (multiple) -k, --pubkey=FILE support to grub-install command
Date: Thu, 19 Sep 2013 09:23:59 +0200 [thread overview]
Message-ID: <523AA68F.6070303@gmail.com> (raw)
In-Reply-To: <1378511958-19974-4-git-send-email-jonmccune@google.com>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
Please update other install methods as well
On 07.09.2013 01:59, Jon McCune wrote:
> +pubkey_file_arg=""
> +if [ x"$pubkey_file_list" != x ]; then
> + for file in $pubkey_file_list; do
> + if [ ! -e "$file" ]; then
> + gettext_printf "Public key file %s not found.\n" "${file}" 1>&2
> + exit 1
> + fi
> + pubkey_file_arg="$pubkey_file_arg --pubkey=$file"
> + done
> +fi
> +
This would go to grub-install_header. Also this code doesn't handle
spaces properly.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
prev parent reply other threads:[~2013-09-19 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 23:59 [PATCH v3 0/3] Add whitelisting support for load_env Jon McCune
2013-09-06 23:59 ` [PATCH v3 1/3] style: indent --no-tabs --gnu-style grub-core/commands/loadenv.c Jon McCune
2013-09-06 23:59 ` [PATCH v3 2/3] load_env support for whitelisting which variables are read from an env file Jon McCune
2013-09-06 23:59 ` [PATCH v3 3/3] Add (multiple) -k, --pubkey=FILE support to grub-install command Jon McCune
2013-09-19 7:23 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523AA68F.6070303@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).