From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VMYb9-00064G-E4 for mharc-grub-devel@gnu.org; Thu, 19 Sep 2013 03:24:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMYaz-00063H-HM for grub-devel@gnu.org; Thu, 19 Sep 2013 03:24:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMYar-0006aN-0s for grub-devel@gnu.org; Thu, 19 Sep 2013 03:24:13 -0400 Received: from mail-ee0-x22a.google.com ([2a00:1450:4013:c00::22a]:33852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMYaq-0006aH-Pc for grub-devel@gnu.org; Thu, 19 Sep 2013 03:24:04 -0400 Received: by mail-ee0-f42.google.com with SMTP id b45so4022792eek.1 for ; Thu, 19 Sep 2013 00:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=OfcsMqfw1VhV2i91rSf6TBeG7StGd3MWSJ9hX70JaxY=; b=e7TLMXRpdQU7hjUYB7ZkeCfzg9/X1vj5Rh3sEsGpRrHZ9ipgWRml4NCTKtau6X/bf9 cNddRrmgef8nQTaWB4Bd8HR7fl7WpuO9RhXaYjQngm7MaYYp9eNMg9t3PTVL0EnjaUwR vy9O9Tv+EuHEVhkuYEVi8DhOYxjKTUnFa6IfppjZvzXq7YbYl9ej5RPrd7O2hEHj4fmQ 6VeAjQL/9ZvLJ4SGdZ2SEsstJcoWjaFbTO76plY9KzNciIIQdnAsilCfs2P8BvitP/zP Ph024wdx1Dwdr3iYwE9oBFAyYsxDa0cFVUX2VkquzkJgjq5p5sZ5lvCUbjQC3Id+DvVd MWsw== X-Received: by 10.14.210.195 with SMTP id u43mr236915eeo.80.1379575444061; Thu, 19 Sep 2013 00:24:04 -0700 (PDT) Received: from [192.168.42.249] (25-227.197-178.cust.bluewin.ch. [178.197.227.25]) by mx.google.com with ESMTPSA id h52sm8987217eez.3.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Sep 2013 00:24:03 -0700 (PDT) Message-ID: <523AA68F.6070303@gmail.com> Date: Thu, 19 Sep 2013 09:23:59 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130821 Icedove/17.0.8 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH v3 3/3] Add (multiple) -k, --pubkey=FILE support to grub-install command References: <1378511958-19974-1-git-send-email-jonmccune@google.com> <1378511958-19974-4-git-send-email-jonmccune@google.com> In-Reply-To: <1378511958-19974-4-git-send-email-jonmccune@google.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2OARGTMLNRFSIVXNSWNAH" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2013 07:24:22 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OARGTMLNRFSIVXNSWNAH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Please update other install methods as well On 07.09.2013 01:59, Jon McCune wrote: > +pubkey_file_arg=3D"" > +if [ x"$pubkey_file_list" !=3D x ]; then > + for file in $pubkey_file_list; do > + if [ ! -e "$file" ]; then > + gettext_printf "Public key file %s not found.\n" "${file}" 1>&= 2 > + exit 1 > + fi > + pubkey_file_arg=3D"$pubkey_file_arg --pubkey=3D$file" > + done > +fi > + This would go to grub-install_header. Also this code doesn't handle spaces properly. ------enig2OARGTMLNRFSIVXNSWNAH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlI6po8ACgkQNak7dOguQgkBOAD8DzdXvSWoV03F/M3h7ayGT5rR pBtbl8fFJxWlo5TvI5cBAJwWOmI7TA9a9SwxSxwQi6ApuFRfY6GVhcGwaH9lHA1G =FInb -----END PGP SIGNATURE----- ------enig2OARGTMLNRFSIVXNSWNAH--