From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VPC6G-000804-IY for mharc-grub-devel@gnu.org; Thu, 26 Sep 2013 09:59:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPC66-0007zm-Fx for grub-devel@gnu.org; Thu, 26 Sep 2013 09:59:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPC5y-0003T6-1s for grub-devel@gnu.org; Thu, 26 Sep 2013 09:59:14 -0400 Received: from mail-ea0-x22e.google.com ([2a00:1450:4013:c01::22e]:50343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPC5x-0003Sy-Qa for grub-devel@gnu.org; Thu, 26 Sep 2013 09:59:05 -0400 Received: by mail-ea0-f174.google.com with SMTP id z15so568185ead.5 for ; Thu, 26 Sep 2013 06:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=EmuqzUWtFq+EtvbxugMZY8w3ImTVVeqfMfYUeAPNaIc=; b=jKoCQp9JTMtHFGwCdnV9uxDV2VYQSkt4o5ycjkfIyBAOInH6XXd/1sBxw31P13DJ0S 27K6he5NJtgYj0e4dQmLq3o2VgxAN3Gzqw1sfHmOpI1PROLoKYNEeiDYHmVM3safqFir qh9uRmtxkD0VxA0dAia0INX4vqdvV0gIGclWfn7bsFeuHO17rOLKX3HjYM0ngBsG5I1e sTURtdkU/Ig1fMMRzE3d+v2S4MQ9SOaq3o+0UFhki+PUolClawSEu02l2V3BTw9Hekmb L956FIUPHCly+QfdnHIxIppF8RNTmOTXu9p7nAKMNGz4kqAFVywH0kyKGwh5/gD7a88D KPxg== X-Received: by 10.14.10.72 with SMTP id 48mr1573154eeu.82.1380203944864; Thu, 26 Sep 2013 06:59:04 -0700 (PDT) Received: from [192.168.1.113] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id d8sm4330763eeh.8.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Sep 2013 06:59:04 -0700 (PDT) Message-ID: <52443DA7.1030707@gmail.com> Date: Thu, 26 Sep 2013 15:59:03 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130821 Icedove/17.0.8 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [RFC] grub-install C rewrite References: <524431E6.60807@gmail.com> <20130926133504.GQ13097@csclub.uwaterloo.ca> In-Reply-To: <20130926133504.GQ13097@csclub.uwaterloo.ca> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2WRUSXKGXOTOHJSDNVKVR" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Sep 2013 13:59:23 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WRUSXKGXOTOHJSDNVKVR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 26.09.2013 15:35, Lennart Sorensen wrote: > On Thu, Sep 26, 2013 at 03:08:54PM +0200, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >> Hello, all. Recently I made some order in hostdisk.c and getroot.c >> involving splitting in OS-specific parts. >> In the same time I added WinAPI version of getroot/hostdisk allowing >> grub-probe to work on windows natively >> Also on-going is AROS-specific parts. >> Windows and AROS are not friendly with bash. >> The attempt to make both multiple files of same type work and handling= >> whitespaces/newlines/... in filenames would result in very ugly code >> with loads of evals. >> Current code may have subtle assumptions on behaviour of common tools >> like sed and on locale (E.g. "[a-z]" doesn't cover u if locale is Esto= nian). >> So to check viability I rewrote grub-install in C. This is mostly proo= f >> of concept with loads of FIXMEs but I could boot i386-pc install made >> with it. In many aspects (static variables, some tests, general >> structure) it's reminiscent of sh version of grub-install it's based o= n. >> Some functionality is likely to stay OS-specific, e.g. executing >> compressors or determining firmware. >> >> I'd like to know the opinion of other people on possible switchover. I= f >> switched then it'll have to be all grub-install, grub-mkrescue, >> grub-mknetdir and grub-mkstandalone. >> I'd like to hear from other people. >=20 > Given the number of times I have had to edit grub-install in the past t= o > get it to work right on a powerpc machine (I think it is now working OK= ), > I would hate to have had that be C code. After all it really is mainly= > a wrapper around other grub tools. >=20 What kind of changes was it? Could we make them into some (possibly hidden) options? > I think windows not having bash is a rather low priority to most people= > compared to actually be able to work with grub on the platforms where > it is pretty much the only choice. >=20 windows is low priority and more of a bonus. The problems of handling anything that looks like a list (e.g. list of devices where / resides on in case of btrfs) and code becoming hairy to handle those cases is bigger reason. > So personally, based on my experience, I hate this idea. >=20 ------enig2WRUSXKGXOTOHJSDNVKVR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlJEPacACgkQNak7dOguQglmqAD/Y8yrnjGOgpOyqt3i2IztCOnU 5MID3M72Zho2YS4Zg2kA/1fXHF5KBRMyi1yhdDpyCmt55CQA8QgGTUPT31IHRo3V =iD2C -----END PGP SIGNATURE----- ------enig2WRUSXKGXOTOHJSDNVKVR--