From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VVpH6-0007fC-Ej for mharc-grub-devel@gnu.org; Mon, 14 Oct 2013 17:02:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVpGz-0007da-2t for grub-devel@gnu.org; Mon, 14 Oct 2013 17:01:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVpGt-0002wR-OQ for grub-devel@gnu.org; Mon, 14 Oct 2013 17:01:53 -0400 Received: from mail-ea0-x22c.google.com ([2a00:1450:4013:c01::22c]:55438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVpGt-0002wF-HX for grub-devel@gnu.org; Mon, 14 Oct 2013 17:01:47 -0400 Received: by mail-ea0-f172.google.com with SMTP id r16so3690515ead.31 for ; Mon, 14 Oct 2013 14:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=anCru+/mOI4JQI93f5t0WJdqD27tYTj7seZR4oaNMMQ=; b=BHI1AicutPIDBujTFqg+7H8PHExU0S6Rax4TT1N5XI1caWgkiGtbmz4bm84zIDKkkF iPrM9s3sIkC2T9+W8OEL4NeyPeWdDViJ0Y0XXApe6PNGjfocq+S6oJJndc55Qg+QC3Ob 4S4cN/hbZAi9gN4SaBC9EMujjN4KSOyN/F6aLFcEzYIT+cogyy0dEgqeCqbzGR4XUSZ/ f+MaDCyTSZjlGMGkdp5R9piexB3bhsWRbfs4gvYBNV9UYgR8nAsMou/v8CZn8n53+o++ WRR4rzrgoLn0rl1TZPkvOyyDB4zt1cauWGQtX5EOJzjq6RaVIwU/tGz0HXhXuPJCVnLY F0Vw== X-Received: by 10.15.35.196 with SMTP id g44mr59449385eev.18.1381784506506; Mon, 14 Oct 2013 14:01:46 -0700 (PDT) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id bn13sm157878767eeb.11.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 14 Oct 2013 14:01:46 -0700 (PDT) Message-ID: <525C5BB9.9030607@gmail.com> Date: Mon, 14 Oct 2013 23:01:45 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: booting btrfs References: <0C284942-C2D0-4520-93B1-3982E6AA38DF@colorremedies.com> <525AF8CD.7050100@gmail.com> <525B2D55.8060502@gmail.com> <339EF7EB-F50A-47F6-99BA-F46ABFECCF74@colorremedies.com> <20131014092807.6917958c@opensuse.site> <3D77CF50-285F-42C2-9325-47AC5ACF5FDC@colorremedies.com> <525C4615.5080803@gmail.com> <04468BB2-5F2D-47BA-8CFC-7C5604FBE315@colorremedies.com> In-Reply-To: <04468BB2-5F2D-47BA-8CFC-7C5604FBE315@colorremedies.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2LFBVSQBLRLVBJSFPTGJG" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Oct 2013 21:01:58 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2LFBVSQBLRLVBJSFPTGJG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 14.10.2013 22:45, Chris Murphy wrote: >=20 > On Oct 14, 2013, at 1:29 PM, Vladimir '=CF=86-coder/phcoder' Serbinenko= wrote: >=20 >>> So it seems that GRUB is using relative pathnames to the default subv= olume. >> This is not intentional. When this part of code was written there was = no >> set-default available at all so this couldn't be tested and I simply >> followed the specification. It told to take root_tree and >> root_dir_objectid from superblock then go to "default" directory. What= >> of this needs to be changed? Just remove "default" and make it part of= >> path? We would need to change grub-mkrelpath to match runtime behaviou= r. >> Is there a way to detect that mountinfo gives garbage and somehow get >> where the real root points? >=20 > Here's the response. It seems similar but not identical to what you des= cribed above. >=20 > http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg27955.html >=20 Possibly this is the answer: =3D=3D=3D modified file 'grub-core/fs/btrfs.c' --- grub-core/fs/btrfs.c 2013-01-21 01:33:46 +0000 +++ grub-core/fs/btrfs.c 2013-10-14 21:00:53 +0000 @@ -1217,7 +1217,7 @@ *type =3D GRUB_BTRFS_DIR_ITEM_TYPE_DIRECTORY; *tree =3D data->sblock.root_tree; - key->object_id =3D data->sblock.root_dir_objectid; + key->object_id =3D grub_cpu_to_le64_compile_time (5); key->type =3D GRUB_BTRFS_ITEM_TYPE_DIR_ITEM; key->offset =3D 0; skip_default =3D 1; ------enig2LFBVSQBLRLVBJSFPTGJG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlJcW7kACgkQNak7dOguQgmhYwEAqJ9ebY3xp+OAiI8/y2W2A3Pi CBH11SnHvkTr61aZqrYBAKYTITHNywOgDoFHMW5e8SEJFU1t1ykmGPi2ZHsLn9Ll =8Cel -----END PGP SIGNATURE----- ------enig2LFBVSQBLRLVBJSFPTGJG--