From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Va5uz-0004ob-Rw for mharc-grub-devel@gnu.org; Sat, 26 Oct 2013 11:36:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Va5us-0004na-Lu for grub-devel@gnu.org; Sat, 26 Oct 2013 11:36:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Va5un-0001S4-55 for grub-devel@gnu.org; Sat, 26 Oct 2013 11:36:42 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:36147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Va5un-0001Rn-04 for grub-devel@gnu.org; Sat, 26 Oct 2013 11:36:37 -0400 X-Authority-Analysis: v=2.0 cv=WP39rwQR c=1 sm=0 a=AxD31EDPJ9zkilLEVKP7ag==:17 a=0e3tnBqgHoYA:10 a=3KVzincvWKMA:10 a=OjrKSnKTdfAA:10 a=103jMkqsgCkA:10 a=BIJj-m-0AAAA:8 a=KGjhK52YXX0A:10 a=G0cz-s6ul4IA:10 a=20KFwNOVAAAA:8 a=6k2sz-PgDAdT5J5y6RAA:9 a=wPNLvfGTeEIA:10 a=vTr9H3xdAAAA:8 a=mnFSM7W8Cd-VzT-5QK8A:9 a=DGUv9C6miAAA:10 a=JGOnqIQd8frS8I1J9jAA:9 a=AxD31EDPJ9zkilLEVKP7ag==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 174.106.200.117 Received: from [174.106.200.117] ([174.106.200.117:56921] helo=condor.lcl) by cdptpa-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id 00/43-17346-C71EB625; Sat, 26 Oct 2013 15:36:30 +0000 Message-ID: <526BE17E.1060802@czarc.net> Date: Sat, 26 Oct 2013 11:36:30 -0400 From: Gene Czarcinski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: BUGS: btrfs multi-device support fixes Content-Type: multipart/mixed; boundary="------------050008060501030005040300" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 75.180.132.120 Cc: Chris Murphy , Gene Czarcinski X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Oct 2013 15:36:48 -0000 This is a multi-part message in MIME format. --------------050008060501030005040300 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit There are two patches needed in grub2 to support multi-device btrfs volumes. This first patch (previously submitted) involves the parameters passed to grub2-probe. If not correctly passed, grub2-probe issues an error message. The related problem report is: https://bugzilla.redhat.com/show_bug.cgi?id=890955 The second problem involves having a multi-device btrfs volume with /boot being on the btrfs volume either as part of the root subvolume or as a separate subvolume. The result is an error messare at boot time: error: no such device: root. hit any key to continue The solution is to modify grub-probe.c so that " " is issued rather than "\n" for a hint. The related problem report is: https://bugzilla.redhat.com/show_bug.cgi?id=1023161 To minimize problems, the two patches have been attached rather than provided inline. Peter, I cc'ed you so you would be aware of these bug reports. It would be nice if this was applied to both Fedora 20 and 19. Gene --------------050008060501030005040300 Content-Type: text/x-patch; name="0001-support-for-multi-device-btrfs-volume.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-support-for-multi-device-btrfs-volume.patch" RnJvbSBiOWVkM2U0OTM1NGY1MTU5ZDk2MmMwODNiNjhjZjA2NzIzYTRhZmY1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRvcmEgTmluamFzIDxncnViMi1vd25lckBmZWRv cmFwcm9qZWN0Lm9yZz4KRGF0ZTogTW9uLCAxNCBPY3QgMjAxMyAxNjoxMTowMCAtMDQwMApT dWJqZWN0OiBbUEFUQ0hdIHN1cHBvcnQgZm9yIG11bHRpLWRldmljZSBidHJmcyB2b2x1bWUK ClRoZSBjdXJyZW50IGNvZGUgcHJvZHVjZXMgZXJyb3IgbWVzc2FnZXMgaWYgcGFzc2VkIGEg ZGV2aWNlCmxpc3Qgd2l0aCBtdWx0aXBsZSBkZXZpY2VzIGZvciBhIGJ0cmZzIHZvbHVtZS4g IEl0IHdvcmtlZCBPSwpmb3Igc2luZ2xlIGRldmljZSBidHJmcyB2b2x1bWUuCgpUaGlzIGhh cyBiZWVuIHJlZ3Jlc3Npb24gdGVzdGVkIHdpdGggcm9vdC9ib290IG9uIGEgcmVndWxhcgpw YXJ0aXRpb24sIHNpbmdsZSBkZXZpY2UgVkcgbG9naWNhbCB2b2x1bWUsIGFuZCBzaW5nbGUK ZGV2aWNlIGJ0cmZzIHZvbHVtZS4KClRoZSBuYW1lIHdhcyBjaGFuZ2UgZnJvbSBkZXZpY2Ug dG8gZGV2aWNlcyB0byBpbmRpY2F0ZSB0aGF0IGl0CmNvdWxkIGJlIGEgZGV2aWNlIGxpc3Qg cGx1cyB0aGUgY29tbWVudHMgd2VyZSBhZGRlZC4KLS0tCiB1dGlsL2dydWItbWtjb25maWdf bGliLmluIHwgNyArKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3V0aWwvZ3J1Yi1ta2NvbmZpZ19saWIuaW4g Yi91dGlsL2dydWItbWtjb25maWdfbGliLmluCmluZGV4IGI0OGUyYWYuLmQ0ZDZiYTAgMTAw NjQ0Ci0tLSBhL3V0aWwvZ3J1Yi1ta2NvbmZpZ19saWIuaW4KKysrIGIvdXRpbC9ncnViLW1r Y29uZmlnX2xpYi5pbgpAQCAtMjcwLDEwICsyNzAsMTMgQEAgZ2V0dGV4dF9wcmludGYgKCkg ewogICBwcmludGYgIiQoZ2V0dGV4dCAiJGdldHRleHRfcHJpbnRmX2Zvcm1hdCIpIiAiJEAi CiB9CiAKKyMgJDEgbWF5IGJlIGEgbGlzdCBvZiBkZXZpY2VzIHNlcGFyYXRlZCBieSBibGFu a3MuICBncnViX3Byb2JlIGFjY2VwdHMKKyMgbXVsdGlwbGUgYXJndW1lbnRzIGFmdGVyIC0t ZGV2aWNlIGJ1dCBlYWNoIGRldmljZSBtdXN0IGJlIGluIGEgc2VwYXJhdGUKKyMgYXJndW1l bnQuICBIZW5jZSAke2RldmljZXN9IHJhdGhlciB0aGFuICIke2RldmljZXN9Ii4KIHVzZXNf YWJzdHJhY3Rpb24gKCkgewotICBkZXZpY2U9IiQxIgorICBkZXZpY2VzPSIkMSIKIAotICBh YnN0cmFjdGlvbj0iYCIke2dydWJfcHJvYmV9IiAtLWRldmljZSAiJHtkZXZpY2V9IiAtLXRh cmdldD1hYnN0cmFjdGlvbmAiCisgIGFic3RyYWN0aW9uPSJgIiR7Z3J1Yl9wcm9iZX0iIC0t ZGV2aWNlICR7ZGV2aWNlc30gLS10YXJnZXQ9YWJzdHJhY3Rpb25gIgogICBmb3IgbW9kdWxl IGluICR7YWJzdHJhY3Rpb259OyBkbwogICAgIGlmIHRlc3QgIngke21vZHVsZX0iID0gIngk MiI7IHRoZW4KICAgICAgIHJldHVybiAwCi0tIAoxLjguMy4xCg== --------------050008060501030005040300 Content-Type: text/x-patch; name="0001-fix-for-hint-problem-with-multi-device-btrfs.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-fix-for-hint-problem-with-multi-device-btrfs.patch" RnJvbSA0YmUxMjJiMGQzYThmOTYxZWFiYTA4ZDY3NjU2YjBhZmJkNzdmNWE1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRvcmEgTmluamFzIDxncnViMi1vd25lckBmZWRv cmFwcm9qZWN0Lm9yZz4KRGF0ZTogU2F0LCAyNiBPY3QgMjAxMyAwNjozNzoyOCAtMDQwMApT dWJqZWN0OiBbUEFUQ0hdIGZpeCBmb3IgaGludCBwcm9ibGVtIHdpdGggbXVsdGkgZGV2aWNl IGJ0cmZzCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD0idXRmLTgiCkNvbnRl bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCkEgYnRyZnMgdm9sdW1lIGNhbiBjb25zaXN0 IG9mIG1vcmUgdGhhbiBvbmUgZGV2aWNlLiAgSGF2aW5nCnRoZSBvdXRwdXQgb24gZGlmZmVy ZW50IGxpbmVzIHNjcmV3cyB1cCB0aGUgc2NyaXB0cyB3aGljaCwKZm9yIHRoZSBtb3N0IHBh cnQsIGV4cGVjdCBvbmx5IGEgc2luZ2xlIGRldmljZS4KLS0tCiB1dGlsL2dydWItcHJvYmUu YyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL3V0aWwvZ3J1Yi1wcm9iZS5jIGIvdXRpbC9ncnViLXByb2JlLmMK aW5kZXggYTQ2ZjBiMS4uZGQ1ZGUwMCAxMDA2NDQKLS0tIGEvdXRpbC9ncnViLXByb2JlLmMK KysrIGIvdXRpbC9ncnViLXByb2JlLmMKQEAgLTU0Myw3ICs1NDMsNyBAQCBwcm9iZSAoY29u c3QgY2hhciAqcGF0aCwgY2hhciAqKmRldmljZV9uYW1lcywgY2hhciBkZWxpbSkKIAkgICAg ICBwcmludF9mdWxsX25hbWUgKG1hcCwgZGV2KTsKIAkgICAgICBwcmludGYgKCInICIpOwog CSAgICB9Ci0JICBwcmludGYgKCJcbiIpOworCSAgcHJpbnRmICgiICIpOyAvKiBuZXctbGlu ZSBjYXVzZXMgcHJvYmxlbXMgZm9yIG11bHRpLWRldmljZSBidHJmcyB2b2x1bWVzICovCiAK IAkgIGdydWJfZGV2aWNlX2Nsb3NlIChkZXYpOwogCSAgY29udGludWU7Ci0tIAoxLjguMy4x Cgo= --------------050008060501030005040300--