From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VaRdF-0005lb-FC for mharc-grub-devel@gnu.org; Sun, 27 Oct 2013 10:47:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaRd8-0005fJ-NB for grub-devel@gnu.org; Sun, 27 Oct 2013 10:47:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VaRd4-0003p5-4U for grub-devel@gnu.org; Sun, 27 Oct 2013 10:47:50 -0400 Received: from mail-qe0-x229.google.com ([2607:f8b0:400d:c02::229]:42280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaRd3-0003oz-Ut for grub-devel@gnu.org; Sun, 27 Oct 2013 10:47:46 -0400 Received: by mail-qe0-f41.google.com with SMTP id x7so3494382qeu.28 for ; Sun, 27 Oct 2013 07:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=exntWhNyq/CgVKiQnr8Q0qx9JVDQUgm9giHCUqQXakQ=; b=tOOKfkBYQIjYXHP4n29y2AuK4x3r+eNzjFqR25S1LtnzsTAnt1R/OAkvNvDV0RLxU7 9bcgrlOITY7ztSojmfmNHfltq/fwXyOihagKFyRUAyjMJ1WzkCGiKE49puGxuUN79gpu z8Dj2oZqPaeqnhJ9XB7urIW/upcPJN49LJz3zHZZS2UC70mRpZbxP4TdocFPk9LgQFx3 NxjKJEBKki4v+h7DCp4CYsJ1yFhsIBal0pSn1A/rcSvoxTRVjdkv8zK95dFOiiu7N5fo ViDyokJQ0X7e0VaK2vGVPuCsOXpt91tIChVx5F8upgnnQ/OuYCvmZg3m1XYI3MKxGvTD 7QSw== X-Received: by 10.49.39.161 with SMTP id q1mr23396038qek.66.1382885265388; Sun, 27 Oct 2013 07:47:45 -0700 (PDT) Received: from condor.lcl (cpe-174-106-200-117.ec.res.rr.com. [174.106.200.117]) by mx.google.com with ESMTPSA id x10sm42471734qas.5.2013.10.27.07.47.43 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 27 Oct 2013 07:47:44 -0700 (PDT) Message-ID: <526D2791.9050308@gmail.com> Date: Sun, 27 Oct 2013 10:47:45 -0400 From: Gene Czarcinski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Andrey Borzenkov , The development of GNU GRUB Subject: Re: BUGS: btrfs multi-device support fixes References: <526BE17E.1060802@czarc.net> <526BED74.6050502@gmail.com> <526C2313.9000703@gmail.com> <20131027105404.7bdc8507@opensuse.site> In-Reply-To: <20131027105404.7bdc8507@opensuse.site> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::229 Cc: Chris Murphy , =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= , Gene Czarcinski X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 14:47:55 -0000 On 10/27/2013 02:54 AM, Andrey Borzenkov wrote: > В Sat, 26 Oct 2013 16:16:19 -0400 > Gene Czarcinski пишет: > >> On 10/26/2013 12:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> Rejected, similar patches is in trunk since some time. >> Thanks. I was not aware that the problem had been addressed. Can you >> point me where to look to see what has been addressed? >> > This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed. And that sure looks like something I would expect to see from a git repository! Look, I am not stupid but I sure am confused! The grub2 website (http://www.gnu.org/software/grub/) says that all grub2 development done through bazaar repository and that you get a copy of the latest grub2 source with: | bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub| Well, I tried doing that and all I get is an error saying: "bzr: ERROR: Not a branch:" Now fedora has a local git repository for grub2 located here: git://pkgs.fedoraproject.org/grub2.git and when I look at what is there I see that the updates (when they come in) appear to be in git format. On other little thing. I I sent this current message there were TWO bug fixes (TWO patch files). I well believe that the first one was already in trunk since I had originally reported that problem in January 2013. The reason I reported it again is because it had not been pick up by fedora. However, there is that second bug fix which I only recently found and fixed. This problem occurs when you have /boot on BTRFS either as a separate subvolume or simply as directory under the root subvolume. In 10_linux, when grub2-probe is call for hint, it returns multi-device hints separated by "\n" which completely screws things up. The patch is: diff --git a/util/grub-probe.c b/util/grub-probe.c index a46f0b1..dd5de00 100644 --- a/util/grub-probe.c +++ b/util/grub-probe.c @@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char delim) print_full_name (map, dev); printf ("' "); } - printf ("\n"); + printf (" "); /* new-line causes problems for multi-device btrfs volumes */ grub_device_close (dev); continue; -- > >> Gene >>> On 26.10.2013 17:36, Gene Czarcinski wrote: >>>> There are two patches needed in grub2 to support multi-device btrfs >>>> volumes. >>>> >>>> This first patch (previously submitted) involves the parameters passed >>>> to grub2-probe. If not correctly passed, grub2-probe issues an error >>>> message. The related problem report is: >>>> https://bugzilla.redhat.com/show_bug.cgi?id=890955 >>>> >>>> The second problem involves having a multi-device btrfs volume with >>>> /boot being on the btrfs volume either as part of the root subvolume or >>>> as a separate subvolume. The result is an error messare at boot time: >>>> error: no such device: root. >>>> hit any key to continue >>>> >>>> The solution is to modify grub-probe.c so that " " is issued rather than >>>> "\n" for a hint. The related problem report is: >>>> https://bugzilla.redhat.com/show_bug.cgi?id=1023161 >>>> >>>> To minimize problems, the two patches have been attached rather than >>>> provided inline. >>>> >>>> Peter, I cc'ed you so you would be aware of these bug reports. It would >>>> be nice if this was applied to both Fedora 20 and 19. >>>> >>>> Gene >>>> >>>> >>>> >>>> _______________________________________________ >>>> Grub-devel mailing list >>>> Grub-devel@gnu.org >>>> https://lists.gnu.org/mailman/listinfo/grub-devel >>>> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >