From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VaUV5-0003zD-Km for mharc-grub-devel@gnu.org; Sun, 27 Oct 2013 13:51:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaUUx-0003ww-Q0 for grub-devel@gnu.org; Sun, 27 Oct 2013 13:51:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VaUUs-0003Ju-Nb for grub-devel@gnu.org; Sun, 27 Oct 2013 13:51:35 -0400 Received: from mail-qa0-x22d.google.com ([2607:f8b0:400d:c00::22d]:32906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaUUs-0003Jq-J8 for grub-devel@gnu.org; Sun, 27 Oct 2013 13:51:30 -0400 Received: by mail-qa0-f45.google.com with SMTP id ii20so1628506qab.18 for ; Sun, 27 Oct 2013 10:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=htrbcA7GJPjXKCaOZd95xUr32g7hVe2xjYpbEY+oxO8=; b=itHcp50r5KBDbMXluxbhncIuLWzKXkT8s0OirGMUo8Zv00wRXo35EoskfEgGnnBVqt E4CL55xFvlhQThGAjZgMzvrswnirKN5kLK5bz8uv8B003qB6ESZ59W5v7j4u5oiyiPYo vNUxG9VhyNjW7IiE8rzfgc3WUeCNqlTdhzhb2b5eJ6KUOnw8sxBylQrN21iFsdARIkiO LIUwlZ2aLtfpOCqajURFfWEcrtnf50EYCCmECGlQfFApmz6p4CH8uS9co9q0/dR/3Jtf rwPN5Ermfod5RMRhUH4vXspmyk1NxCQu3eXeWnz2qfX1CI26W+8igfWL/Db7mR2wHM/Q fdJw== X-Received: by 10.229.16.137 with SMTP id o9mr24385666qca.0.1382896290120; Sun, 27 Oct 2013 10:51:30 -0700 (PDT) Received: from condor.lcl (cpe-174-106-200-117.ec.res.rr.com. [174.106.200.117]) by mx.google.com with ESMTPSA id a9sm35250766qed.6.2013.10.27.10.51.28 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 27 Oct 2013 10:51:29 -0700 (PDT) Message-ID: <526D52A2.8090204@gmail.com> Date: Sun, 27 Oct 2013 13:51:30 -0400 From: Gene Czarcinski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Andrey Borzenkov Subject: Re: BUGS: btrfs multi-device support fixes References: <526BE17E.1060802@czarc.net> <526BED74.6050502@gmail.com> <526C2313.9000703@gmail.com> <20131027105404.7bdc8507@opensuse.site> <526D2791.9050308@gmail.com> <20131027192428.5fe0ef59@opensuse.site> In-Reply-To: <20131027192428.5fe0ef59@opensuse.site> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c00::22d Cc: Chris Murphy , The development of GNU GRUB , Gene Czarcinski , =?UTF-8?B?VmxhZGltaQ==?= =?UTF-8?B?ciAnz4YtY29kZXIvcGhjb2RlcicgU2VyYmluZW5rbw==?= X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 17:51:40 -0000 On 10/27/2013 11:24 AM, Andrey Borzenkov wrote: > В Sun, 27 Oct 2013 10:47:45 -0400 > Gene Czarcinski пишет: > >> On 10/27/2013 02:54 AM, Andrey Borzenkov wrote: >>> В Sat, 26 Oct 2013 16:16:19 -0400 >>> Gene Czarcinski пишет: >>> >>>> On 10/26/2013 12:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>>>> Rejected, similar patches is in trunk since some time. >>>> Thanks. I was not aware that the problem had been addressed. Can you >>>> point me where to look to see what has been addressed? >>>> >>> This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed. >> And that sure looks like something I would expect to see from a git >> repository! >> >> Look, I am not stupid but I sure am confused! The grub2 website >> (http://www.gnu.org/software/grub/) says that all grub2 development done >> through bazaar repository and that you get a copy of the latest grub2 >> source with: | >> bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub| >> Well, I tried doing that and all I get is an error saying: "bzr: ERROR: >> Not a branch:" >> > That's where website lags behind. GRUB switched to GIT a while ago. See > > https://savannah.gnu.org/git/?group=grub Thank you, thank you. This helps a great deal. In a way, I am not surprised that you switched to git as I find that most projects I contribute to are using git repositories and, personally, I find them easy to use. Concerning the patches I submitted, if I had access to the repository before I submitted them, I never would have submitted them. I would also have saved myself a lot of time and effort because right about the time this patch was added is about the time I was troubleshooting multi-device BTRFS. Gene > > As for web site - I do not know; Vladimir, who can edit this? > >> Now fedora has a local git repository for grub2 located here: >> git://pkgs.fedoraproject.org/grub2.git and when I look at what is there >> I see that the updates (when they come in) appear to be in git format. >> >> On other little thing. I I sent this current message there were TWO bug >> fixes (TWO patch files). I well believe that the first one was already >> in trunk since I had originally reported that problem in January 2013. >> The reason I reported it again is because it had not been pick up by fedora. >> >> However, there is that second bug fix which I only recently found and >> fixed. This problem occurs when you have /boot on BTRFS either as a >> separate subvolume or simply as directory under the root subvolume. In >> 10_linux, when grub2-probe is call for hint, it returns multi-device >> hints separated by "\n" which completely screws things up. The patch is: >> diff --git a/util/grub-probe.c b/util/grub-probe.c >> index a46f0b1..dd5de00 100644 >> --- a/util/grub-probe.c >> +++ b/util/grub-probe.c >> @@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char >> delim) >> print_full_name (map, dev); >> printf ("' "); >> } >> - printf ("\n"); >> + printf (" "); /* new-line causes problems for multi-device btrfs >> volumes */ >> >> grub_device_close (dev); >> continue; >