From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VdB56-0006mW-8V for mharc-grub-devel@gnu.org; Sun, 03 Nov 2013 22:44:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdB50-0006mO-Pd for grub-devel@gnu.org; Sun, 03 Nov 2013 22:43:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdB4w-0002Tw-BC for grub-devel@gnu.org; Sun, 03 Nov 2013 22:43:54 -0500 Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]:41134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdB4w-0002Tq-3F for grub-devel@gnu.org; Sun, 03 Nov 2013 22:43:50 -0500 Received: by mail-ea0-f178.google.com with SMTP id a10so324558eae.9 for ; Sun, 03 Nov 2013 19:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=Naf0ODAekP7CYiUqI6aGjSICHs5058THjRX93k7hXy0=; b=GTnrliLHJdXzYEAc0cYYvVb3N7BizvTJ7xNJOA7OUVqvWV0y9j+l2Voj02TH9nSboy EcakTKMeRzKfbsrZq6IAdf6mIPEtLQa2bCIIC+oy8sokA8owiVskC6GyjY/fQerWswpg mTUBt1KNcvPR9mffMr9D9a3f1H6VB889E8OBaHbVvpUOao4zt4ckM7VhGHW1JHn67hj7 t8EBrCm9IJGo8NGhmYRCoCLMqBE066RXSeGApXN2PNVcYRMC3zS2lGHZCW6tCO/nUu5p TiQmJJ1P8ld2AePJBSQ/6c49KxiYby37+byzLJGXEjenwtL5ZvWiGZ0dxC/N7pXgUhuD jKkA== X-Received: by 10.14.198.197 with SMTP id v45mr5079626een.52.1383536629123; Sun, 03 Nov 2013 19:43:49 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id b42sm40997727eem.9.2013.11.03.19.43.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 03 Nov 2013 19:43:48 -0800 (PST) Message-ID: <527717ED.7040806@gmail.com> Date: Mon, 04 Nov 2013 04:43:41 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] enable emuusb and emupci on emu platform only References: <1374389627-26694-1-git-send-email-arvidjaar@gmail.com> <51F139B8.7000500@gmail.com> <20130725210645.100a1ae5@opensuse.site> In-Reply-To: <20130725210645.100a1ae5@opensuse.site> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2BGINUABKMTIKMPXIXQJO" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::232 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Nov 2013 03:43:59 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BGINUABKMTIKMPXIXQJO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Go ahead. I mistagged this one in my inbox and hence missed it, sorry for this On 25.07.2013 19:06, Andrey Borzenkov wrote: > =D0=92 Thu, 25 Jul 2013 16:44:08 +0200 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 >> On 21.07.2013 08:53, Andrey Borzenkov wrote: >>> Is there any reason we may want to build them when not building >>> --with-platform=3Demu? >>> >> I think it's better to reset COND_EMU_PCI/COND_EMU_USB to false in=20 >> configure state when not compiling for emu as usage of both enable and= =20 >> consition simultaneously is marginal and it's beter not to rely on it = >> (so to i.a. permit its removal if necessary) >=20 > I think it makes sense to use both. "enable =3D emu" makes it obvious > that module should not be built on other platform. It also makes > resulting Makefile.am slightly more readable. >=20 > Actually it is already used this way for SDL. >=20 > Like this? >=20 > diff --git a/configure.ac b/configure.ac > index 4fe20a3..acd37f2 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -949,6 +949,13 @@ fi > AC_SUBST([enable_grub_emu_sdl]) > AC_SUBST([enable_grub_emu_usb]) > AC_SUBST([enable_grub_emu_pci]) > + > +else > + > +# Ignore --enable-emu-* if platform is not emu > +enable_grub_emu_sdl=3Dno > +enable_grub_emu_usb=3Dno > +enable_grub_emu_pci=3Dno > fi > =20 > AC_ARG_ENABLE([grub-mkfont], > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > index 06617d7..230bed5 100644 > --- a/grub-core/Makefile.core.def > +++ b/grub-core/Makefile.core.def > @@ -477,6 +477,7 @@ module =3D { > module =3D { > name =3D emuusb; > common =3D bus/usb/usb.c; > + enable =3D emu; > condition =3D COND_GRUB_EMU_USB; > }; > =20 > @@ -546,6 +547,7 @@ module =3D { > common =3D bus/emu/pci.c; > common =3D commands/lspci.c; > =20 > + enable =3D emu; > condition =3D COND_GRUB_EMU_PCI; > }; > =20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2BGINUABKMTIKMPXIXQJO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlJ3F+0ACgkQmBXlbbo5nOsASwD8CjQW1HXvxl2wUgVWgEsCONl0 idzILP9N3wZ3d4rF764A/AwXuocCP4FWO3ddjtvT5hHeK0Yzm94jmSWy0O1pBQWF =Ix2G -----END PGP SIGNATURE----- ------enig2BGINUABKMTIKMPXIXQJO--