From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: grub_machine_fini definition inconsistencies
Date: Sun, 10 Nov 2013 13:33:48 +0100 [thread overview]
Message-ID: <527F7D2C.4000002@gmail.com> (raw)
In-Reply-To: <20131110005608.000a28da@crass-Ideapad-Z570>
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
On 10.11.2013 07:56, Glenn Washburn wrote:
> I'm now getting compilation errors for platform efi.
>
> /home/crass/development/bootloader/grub2-src/grub.git/grub-core/lib/efi/halt.c:
> In function
> ‘grub_halt’: /home/crass/development/bootloader/grub2-src/grub.git/grub-core/lib/efi/halt.c:30:3:
> error: too few arguments to function ‘grub_machine_fini’ In file
> included
> from /home/crass/development/bootloader/grub2-src/grub.git/grub-core/lib/efi/halt.c:24:0: /home/crass/development/bootloader/grub2-src/grub.git/include/grub/kernel.h:117:6:
> note: declared here
>
> grub_machine_fini is defined to take one int argument in
> include/grub/kernel.h, however grub-core/lib/efi/halt.c is calling
> grub_machine_fini with no arguments. Grep has shown several such
> invocations.
>
Fixed, thanks
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-11-10 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 6:56 grub_machine_fini definition inconsistencies Glenn Washburn
2013-11-10 12:33 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-11-10 23:41 ` Glenn Washburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527F7D2C.4000002@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).