From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VfWAx-0007mL-87 for mharc-grub-devel@gnu.org; Sun, 10 Nov 2013 09:39:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VfWAn-0007lY-NE for grub-devel@gnu.org; Sun, 10 Nov 2013 09:39:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VfWAf-00045l-9O for grub-devel@gnu.org; Sun, 10 Nov 2013 09:39:33 -0500 Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:59056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VfWAf-00044e-1L for grub-devel@gnu.org; Sun, 10 Nov 2013 09:39:25 -0500 Received: by mail-ee0-f45.google.com with SMTP id c4so415117eek.4 for ; Sun, 10 Nov 2013 06:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=Sde231OzlA2Rs+RkRMsAfN1C6R6jyTBqUv8jj0W7mPU=; b=bi8iOq+u5+r8YuqArE63qDTkazXua+fATsppE/+0ajqRma5Ckgj3iWCrkKzI7otmdF F+79DlqjHhyFLrVQ4g/h4Ry8rXyacj1XAhz45Bc9zXbkpJbtGP2UvSVcAmS5lxv2M0hv rr2Nzez3NACZop0DSGKZuTiMbOChLunLLFBOYDd9SpynvJC9D19bcK0453T3LETpuiYl 391vSbfez/K6KeONYAvJQoDqhii7dVN2eEyQVFZns3HQgWnX/qxRJiqRLv3SQY10IBlG eRbIvITqlA3u2891vntQiIM6RO1HEJRqHpFwWJ1BvDQKLf2irI8xxkGZQPaL8fSYWyaN M21A== X-Received: by 10.15.10.6 with SMTP id f6mr254930eet.57.1384094364088; Sun, 10 Nov 2013 06:39:24 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id w6sm49976734eeo.12.2013.11.10.06.39.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 10 Nov 2013 06:39:23 -0800 (PST) Message-ID: <527F9A98.8040406@gmail.com> Date: Sun, 10 Nov 2013 15:39:20 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] fix qsort invocation in grub-install References: <527F8B1E.8040303@gmail.com> <1384093584-19666-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1384093584-19666-1-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2HFBBRTLDBMPTIMPTTFIH" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Nov 2013 14:39:42 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HFBBRTLDBMPTIMPTTFIH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10.11.2013 15:26, Andrey Borzenkov wrote: > Order of elements number and size is reversed. >=20 Go ahead. > --- > util/grub-install.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/util/grub-install.c b/util/grub-install.c > index 11010cc..87a0b3b 100644 > --- a/util/grub-install.c > +++ b/util/grub-install.c > @@ -560,7 +560,7 @@ device_map_check_duplicates (const char *dev_map) > =20 > fclose (fp); > =20 > - qsort (d, sizeof (d[0]), filled, (int (*) (const void *, const void = *))strcmp); > + qsort (d, filled, sizeof (d[0]), (int (*) (const void *, const void = *))strcmp); > =20 > for (i =3D 0; i + 1 < filled; i++) > if (strcmp (d[i], d[i+1]) =3D=3D 0) >=20 ------enig2HFBBRTLDBMPTIMPTTFIH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlJ/mpkACgkQmBXlbbo5nOvAjQD+MUVNNjLKajYirOImdkWjiFJY U90MhYZfR5K11f2+VxEBAJDO1X3oRinYBdtqvi5Q+RpUFq2SKACtZ2490wbmY6d8 =2axw -----END PGP SIGNATURE----- ------enig2HFBBRTLDBMPTIMPTTFIH--