[PATCH] grub2 should not unzip Linux initramfs

* [PATCH] grub2 should not unzip Linux initramfs
@ 2013-11-12 10:25 Lukas Schwaighofer
  2013-11-12 20:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Schwaighofer @ 2013-11-12 10:25 UTC (permalink / raw)
  To: grub-devel


[-- Attachment #1.1: Type: text/plain, Size: 852 bytes --]

Hi,

the initramfs protocol (see [1]) supports multiple concatenated archives.

Because of grub2's implicit unzipping of gz-compressed multiboot
modules, a valid initramfs-file (e.g. in my case containing of two
concatenated gz-files) may be rendered unbootable.

I have attached the trivial patch adding --nounzip to the the
appropriate module-directive when generating XEN boot entries. As this
resembles the behavior when booting without XEN (using the grub2
commands linux and initrd) more closely I don't expect any problems.

I have reported this to the Debian bugtracker before [2] with no
response, but I suppose this is the correct point to report this issue.

Thank you
Lukas


[1]
https://www.kernel.org/doc/Documentation/early-userspace/buffer-format.txt
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700197


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: xen_initrd_nounzip.patch --]
[-- Type: text/x-patch; name="xen_initrd_nounzip.patch", Size: 489 bytes --]

diff --git a/util/grub.d/20_linux_xen.in b/util/grub.d/20_linux_xen.in
index 4cf93d2..f12f059 100644
--- a/util/grub.d/20_linux_xen.in
+++ b/util/grub.d/20_linux_xen.in
@@ -135,7 +135,7 @@ EOF
     message="$(gettext_printf "Loading initial ramdisk ...")"
     sed "s/^/$submenu_indentation/" << EOF
 	echo	'$(echo "$message" | grub_quote)'
-	module	${rel_dirname}/${initrd}
+	module	--nounzip   ${rel_dirname}/${initrd}
 EOF
   fi
   sed "s/^/$submenu_indentation/" << EOF


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread