From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vgcl9-00026r-Gy for mharc-grub-devel@gnu.org; Wed, 13 Nov 2013 10:53:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgckz-00026a-TS for grub-devel@gnu.org; Wed, 13 Nov 2013 10:53:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vgckr-0008R4-FS for grub-devel@gnu.org; Wed, 13 Nov 2013 10:53:29 -0500 Received: from mail-ee0-x22a.google.com ([2a00:1450:4013:c00::22a]:58359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgckr-0008Q7-3v for grub-devel@gnu.org; Wed, 13 Nov 2013 10:53:21 -0500 Received: by mail-ee0-f42.google.com with SMTP id e52so313981eek.1 for ; Wed, 13 Nov 2013 07:53:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=l0dbDwS5oEMMd90/hf6U1guatorMW6aYQmivV4hSJPg=; b=HNS/6t+XZcRskx7Suz9hZ3ocEr5wlrxorYkMceRBsVsL27jeQjs5xFxCtEg/55NEPf qkw3TZ950RkX1EpMAvE8Gp1XtwXKasn/jNz9OuwsfKF3xoeI63GyqPgKVaLuLLWVm5S8 8dq+TtYIFyhJC6yWYXEUn5qPKFtv3ZsirPx5ZgYsSG9hAs2chi6I4yE9xCZtUZPew9/J CX/xS42xn1K+QR84RJkTam7nb/tQO4bF5J3+PFSXYPxmjV9vabUphv3tEifjEhPKqfhM oPqk9rV5JuGUtRgk+cgcEzjdRKBs1ZKVBHSwFu487Z4vwC42APJCLSktZj1rLfcDtsQw 3dBQ== X-Received: by 10.14.1.130 with SMTP id 2mr50261872eed.24.1384357503330; Wed, 13 Nov 2013 07:45:03 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id x4sm89177576eef.1.2013.11.13.07.45.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 13 Nov 2013 07:45:02 -0800 (PST) Message-ID: <52839E7C.2060408@gmail.com> Date: Wed, 13 Nov 2013 16:45:00 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: arm-uboot: misc.S:56: Error: r13 not allowed here -- `sub sp, fp, #4' References: <20131113144919.GB30137@riva.ucam.org> <528397A9.5020406@gmail.com> <20131113153654.GV1557@rocoto.smurfnet.nu> In-Reply-To: <20131113153654.GV1557@rocoto.smurfnet.nu> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2IQLILOPGFRJXEWVWBWNS" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2013 15:53:38 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2IQLILOPGFRJXEWVWBWNS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 13.11.2013 16:36, Leif Lindholm wrote: > On Wed, Nov 13, 2013 at 04:15:53PM +0100, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >> On 13.11.2013 15:49, Colin Watson wrote: >>> After my previous fix, arm-uboot still fails to build with: >>> >>> arm-linux-gnueabihf-gcc -DHAVE_CONFIG_H -I. -I../../../grub-core -I= =2E. -Wall -W -I../../../include -I../include -DGRUB_MACHINE_UBOOT=3D1 = -DGRUB_MACHINE_ARM=3D1 -DGRUB_MACHINE=3DARM_UBOOT -DGRUB_TARGET_CPU_ARM=3D= 1 -nostdinc -isystem /usr/lib/gcc-cross/arm-linux-gnueabihf/4.8/include -= DGRUB_FILE=3D\"lib/arg.c\" -I. -I../../../grub-core -I.. -I../../.. -I../= =2E./../include -I../include -I../../../grub-core/lib/libgcrypt-grub/incl= ude -I../../../grub-core/lib/libgcrypt-grub/src/ -DGRUB_KERNEL=3D1 -O= s -Wall -W -Wshadow -Wold-style-definition -Wpointer-arith -Wundef -Wextr= a -Wattributes -Wchar-subscripts -Wcomment -Wdeprecated-declarations -Wdi= sabled-optimization -Wdiv-by-zero -Wendif-labels -Wfloat-equal -Wformat-e= xtra-args -Wformat-security -Wformat-y2k -Wimplicit -Wimplicit-function-d= eclaration -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch= -Wmain -Wmissing-braces -Wmissing-field-initializers -Wmissing-format-at= tribute -Wmultichar -Wnonnull -Woverflow -Wparentheses -Wpointer- ar >> ith -Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsi= gn-compare -Wstrict-aliasing -Wswitch -Wtrigraphs -Wundef -Wunknown-pragm= as -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-= value -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrit= e-strings -Wnested-externs -Wstrict-prototypes -Wpointer-sign -g -Wredund= ant-decls -Wmissing-prototypes -Wmissing-declarations -Wcast-align -freg-= struct-return -fno-dwarf2-cfi-asm -fno-asynchronous-unwind-tables -fno-st= ack-protector -mno-unaligned-access -Wtrampolines -Werror -DUSE_ASCII_FAL= LBACK=3D1 -DHAVE_UNIFONT_WIDTHSPEC=3D1 -mthumb-interwork -mlong-calls= -ffreestanding -MT lib/kernel_exec-arg.o -MD -MP -MF lib/.deps-core/ke= rnel_exec-arg.Tpo -c -o lib/kernel_exec-arg.o `test -f 'lib/arg.c' || ech= o '../../../grub-core/'`lib/arg.c >>> misc.S: Assembler messages: >>> misc.S:56: Error: r13 not allowed here -- `sub sp,fp,#4' >>> make[3]: *** [kern/arm/kernel_exec-misc.o] Error 1 >>> >>> I don't think SP can be used that way in Thumb mode? >>> >> I think that our asm routines should be in full ARM. Attached patch >> follows this strategy. One remaining problem is to make sure that thum= b >> flags in TARGET_CFLAGS and TARGET_CCASFLAGS match. >=20 > There should be no need for this - the only thing is to ensure the > -mthumb-interwork is set in CCASFLAGS_PLATFORM as well as > CFLAGS_PLATFORM, and even that is just to prevent linker warnings.. >=20 > There is no special ARM_PROLOGUE needed, and (on armv5te onwards) > pop {..., pc} is an interworking branch. >=20 > If we want to force a file to build as ARM (which I'm not sure is > necessary now that we have split up armv6 separate from later > architectures), all that is required is a .arm directive up top. >=20 Hm. I'm confused. According to http://stuff.mit.edu/afs/sipb/project/egcs/src/egcs/gcc/config/arm/README= -interworking: "Note that specifying -mthumb-interwork does result in slightly larger, slower code being produced. This is why interworking support must be specifically enabled by a switch." ------enig2IQLILOPGFRJXEWVWBWNS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKDnnwACgkQmBXlbbo5nOtJsgD/fyzQphOpLNLvwSXs/lph4dIh Opz9Osxl59rufr4ODfQBAIQhVRJLl6MGY0DO2xTBAB4BmBWZzSO+sfTL+Lak3yNM =wwgM -----END PGP SIGNATURE----- ------enig2IQLILOPGFRJXEWVWBWNS--