* [PATCH] Compile asm-files to thumb2
@ 2013-11-14 7:39 Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 15:17 ` Leif Lindholm
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2013-11-14 7:39 UTC (permalink / raw)
To: The development of GRUB 2
[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]
diff --git a/grub-core/kern/arm/cache.S b/grub-core/kern/arm/cache.S
index 8522d24..2ad774d 100644
--- a/grub-core/kern/arm/cache.S
+++ b/grub-core/kern/arm/cache.S
@@ -21,7 +21,12 @@
.file "cache.S"
.text
.syntax unified
+#if !defined (__thumb2__) || !defined (ARMV7)
.arm
+#else
+ .thumb
+#endif
+
#if !defined (ARMV6) && !defined (ARMV7)
# error Unsupported architecture version!
#endif
diff --git a/grub-core/kern/arm/cache_armv7.S b/grub-core/kern/arm/cache_armv7.S
index 0c16b10..aa42fad 100644
--- a/grub-core/kern/arm/cache_armv7.S
+++ b/grub-core/kern/arm/cache_armv7.S
@@ -21,8 +21,13 @@
.file "cache_armv7.S"
.text
.syntax unified
- .arm
+#if !defined (__thumb2__)
.arch armv7a
+ .arm
+#else
+ .arch armv7
+ .thumb
+#endif
# define DMB dmb
# define DSB dsb
# define ISB isb
@@ -58,11 +63,17 @@ clean_invalidate_dcache:
@ read current cache information
mrc p15, 1, r8, c0, c0, 0 @ Read CCSIDR
lsr r3, r8, #13 @ Number of sets -1
- ldr r9, =0x3fff
- and r3, r3, r9
+
+ @ Keep only 14 bits of r3
+ lsl r3, r3, #18
+ lsr r3, r3, #18
+
lsr r4, r8, #3 @ Number of ways -1
- ldr r9, =0x1ff
- and r4, r4, r9
+
+ @ Keep only 9 bits of r4
+ lsl r4, r4, #23
+ lsr r4, r4, #23
+
and r7, r8, #7 @ log2(line size in words) - 2
add r7, r7, #2 @ adjust
mov r8, #1
diff --git a/grub-core/lib/arm/setjmp.S b/grub-core/lib/arm/setjmp.S
index 4f15679..b6febfb 100644
--- a/grub-core/lib/arm/setjmp.S
+++ b/grub-core/lib/arm/setjmp.S
@@ -24,7 +24,11 @@
GRUB_MOD_LICENSE "GPLv3+"
.syntax unified
+#if !defined (__thumb2__)
.arm
+#else
+ .thumb
+#endif
.text
@@ -32,7 +36,8 @@ GRUB_MOD_LICENSE "GPLv3+"
* int grub_setjmp (grub_jmp_buf env)
*/
FUNCTION(grub_setjmp)
- stm r0, { r4-r11, sp, lr }
+ stm r0, { r4-r11, lr }
+ str sp, [r0, #36 ]
mov r0, #0
bx lr
@@ -40,7 +45,10 @@ FUNCTION(grub_setjmp)
* int grub_longjmp (grub_jmp_buf env, int val)
*/
FUNCTION(grub_longjmp)
- ldm r0, { r4-r11, sp, lr }
+ ldm r0, { r4-r11, lr }
+ ldr sp, [r0, #36 ]
movs r0, r1
- moveq r0, #1
+ bne 1f
+ mov r0, #1
+1:
bx lr
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Compile asm-files to thumb2
2013-11-14 7:39 [PATCH] Compile asm-files to thumb2 Vladimir 'φ-coder/phcoder' Serbinenko
@ 2013-11-16 15:17 ` Leif Lindholm
0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2013-11-16 15:17 UTC (permalink / raw)
To: The development of GNU GRUB
Hi Vladimir,
The code looks/appears correct - a few comments inline.
On Thu, Nov 14, 2013 at 08:39:31AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> diff --git a/grub-core/kern/arm/cache.S b/grub-core/kern/arm/cache.S
> index 8522d24..2ad774d 100644
> --- a/grub-core/kern/arm/cache.S
> +++ b/grub-core/kern/arm/cache.S
> @@ -21,7 +21,12 @@
> .file "cache.S"
> .text
> .syntax unified
> +#if !defined (__thumb2__) || !defined (ARMV7)
> .arm
> +#else
> + .thumb
> +#endif
> +
> #if !defined (ARMV6) && !defined (ARMV7)
> # error Unsupported architecture version!
> #endif
> diff --git a/grub-core/kern/arm/cache_armv7.S b/grub-core/kern/arm/cache_armv7.S
> index 0c16b10..aa42fad 100644
> --- a/grub-core/kern/arm/cache_armv7.S
> +++ b/grub-core/kern/arm/cache_armv7.S
> @@ -21,8 +21,13 @@
> .file "cache_armv7.S"
> .text
> .syntax unified
> - .arm
> +#if !defined (__thumb2__)
> .arch armv7a
> + .arm
> +#else
> + .arch armv7
> + .thumb
> +#endif
I think ".arch armv7a" could be moved outside of the #if statement,
and the ".arch armv7" could be dropped.
> # define DMB dmb
> # define DSB dsb
> # define ISB isb
> @@ -58,11 +63,17 @@ clean_invalidate_dcache:
> @ read current cache information
> mrc p15, 1, r8, c0, c0, 0 @ Read CCSIDR
> lsr r3, r8, #13 @ Number of sets -1
> - ldr r9, =0x3fff
> - and r3, r3, r9
> +
> + @ Keep only 14 bits of r3
> + lsl r3, r3, #18
> + lsr r3, r3, #18
> +
> lsr r4, r8, #3 @ Number of ways -1
> - ldr r9, =0x1ff
> - and r4, r4, r9
> +
> + @ Keep only 9 bits of r4
> + lsl r4, r4, #23
> + lsr r4, r4, #23
> +
> and r7, r8, #7 @ log2(line size in words) - 2
> add r7, r7, #2 @ adjust
> mov r8, #1
> diff --git a/grub-core/lib/arm/setjmp.S b/grub-core/lib/arm/setjmp.S
> index 4f15679..b6febfb 100644
> --- a/grub-core/lib/arm/setjmp.S
> +++ b/grub-core/lib/arm/setjmp.S
> @@ -24,7 +24,11 @@
> GRUB_MOD_LICENSE "GPLv3+"
>
> .syntax unified
> +#if !defined (__thumb2__)
> .arm
> +#else
> + .thumb
> +#endif
>
> .text
>
> @@ -32,7 +36,8 @@ GRUB_MOD_LICENSE "GPLv3+"
> * int grub_setjmp (grub_jmp_buf env)
> */
> FUNCTION(grub_setjmp)
> - stm r0, { r4-r11, sp, lr }
> + stm r0, { r4-r11, lr }
> + str sp, [r0, #36 ]
I would lean towards writing this as
mov r12, sp
stm r0, { r4-r12, lr }
just to skip the manual arithmetic.
> mov r0, #0
> bx lr
>
> @@ -40,7 +45,10 @@ FUNCTION(grub_setjmp)
> * int grub_longjmp (grub_jmp_buf env, int val)
> */
> FUNCTION(grub_longjmp)
> - ldm r0, { r4-r11, sp, lr }
> + ldm r0, { r4-r11, lr }
> + ldr sp, [r0, #36 ]
Same here:
ldm r0, { r4-r12, lr }
mov sp, r12
> movs r0, r1
> - moveq r0, #1
> + bne 1f
> + mov r0, #1
> +1:
Alternatively we could (because we have .syntax unified)
use
it eq
moveq r0, #1
> bx lr
>
/
Leif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-16 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-14 7:39 [PATCH] Compile asm-files to thumb2 Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 15:17 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).