From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vgrrz-0007fm-7M for mharc-grub-devel@gnu.org; Thu, 14 Nov 2013 03:01:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgrrp-0007fG-Tw for grub-devel@gnu.org; Thu, 14 Nov 2013 03:01:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vgrrh-0000fU-Bg for grub-devel@gnu.org; Thu, 14 Nov 2013 03:01:33 -0500 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:58574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgrrh-0000fN-4u for grub-devel@gnu.org; Thu, 14 Nov 2013 03:01:25 -0500 Received: by mail-wg0-f45.google.com with SMTP id a1so1523338wgh.24 for ; Thu, 14 Nov 2013 00:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=W8R/4evBBIQNVhTUq+5VBoAE90SogN1Jq5+dBijvfdY=; b=d9X0UxY5gC8KFw+UWXZ8z3wWzowXfyXLGRKv41BGUb1vAseuzgEeJH9lpuG0SRfCa4 FzgV5+aaiLkB/KIeA+7+Iu2SV9tPOovQMlCxN5fradZETGoN5bkTih+PloFnQnGWCxsQ tD9DZZjBgJwiqPg3bHpAHmmKD9FM5/XF4fPxAiwOJnChrKuSb+mIXQLbZJRq9YAzPdKk F8AMZ+rU0vMWZmnQtFTDUCpvK6Wck7GyvKL/+nDKKmMI28Ons9yUzqF4UeJVMg019kuj VKU3ILy0/OZJtwc3b/23jyk0crazfRyyZtI+eDF1RcxJJXmaSIeHeZv5rHCX34wGPApE 0R2w== X-Received: by 10.194.240.41 with SMTP id vx9mr150255wjc.70.1384416084107; Thu, 14 Nov 2013 00:01:24 -0800 (PST) Received: from [192.168.42.82] (8-237.197-178.cust.bluewin.ch. [178.197.237.8]) by mx.google.com with ESMTPSA id b42sm97041828eem.9.2013.11.14.00.01.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 14 Nov 2013 00:01:23 -0800 (PST) Message-ID: <5284834F.3040604@gmail.com> Date: Thu, 14 Nov 2013 09:01:19 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as required by ABI References: In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2GBMAUKMSFRFVMLHDHILG" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 08:01:42 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GBMAUKMSFRFVMLHDHILG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable >=20 > diff --git a/grub-core/kern/x86_64/efi/startup.S b/grub-core/kern/x86_6= 4/efi/startup.S > index f86f019..94bd6ae 100644 > --- a/grub-core/kern/x86_64/efi/startup.S > +++ b/grub-core/kern/x86_64/efi/startup.S > @@ -29,7 +29,11 @@ start: > _start: > movq %rcx, EXT_C(grub_efi_image_handle)(%rip) > movq %rdx, EXT_C(grub_efi_system_table)(%rip) > - > + mov %rsp, %rax > + subq $8, %rsp > + and $~0xf, %rsp > + mov %rax, (%rsp) > call EXT_C(grub_main) > + mov (%rsp), %rsp This would be useful if we ever returned but we never do (we call boot_services->exit instead). Could you instead prepare a patch which does stack alignment and removed the "ret" putting instead a comment /* Doesn't return. */ ? > ret > =20 >=20 ------enig2GBMAUKMSFRFVMLHDHILG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKEg08ACgkQmBXlbbo5nOuMsAD+Kmi3hFj/mx8VZ5rAl0P+bvnl FQ/9O9swe3DvMCSGxYoA/jEoGUldnqRA81AmoGSaN62xpU1iLtoPCWzhDFPLm7nt =Edz4 -----END PGP SIGNATURE----- ------enig2GBMAUKMSFRFVMLHDHILG--