From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VgxZL-0006H2-Jb for mharc-grub-devel@gnu.org; Thu, 14 Nov 2013 09:06:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgxZB-00067H-VU for grub-devel@gnu.org; Thu, 14 Nov 2013 09:06:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgxZ5-0001Ix-Ce for grub-devel@gnu.org; Thu, 14 Nov 2013 09:06:41 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:51427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgxZ5-0001Is-5M for grub-devel@gnu.org; Thu, 14 Nov 2013 09:06:35 -0500 Received: by mail-wg0-f42.google.com with SMTP id k14so739802wgh.5 for ; Thu, 14 Nov 2013 06:06:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=dP4fgCYumdUYQMVYDpHHuDsSRmjIp7t94QvJxuQhKTw=; b=BVwl2cPzipdE9F2yFoJrelWKU2kFMzDogDwR74SkjMAhNFm3RArg9mMlTdj5Hit5xc PqnikgINd2c64Eihckh4yQ1vkE6vZdzLzwpq0T+IjHnAksFeT0jMB4M1bD68+N26hPmM 37V3R8Ultz8i/JDlgKfHCHc4t98pNNOmuXiBEkfdyrkfMet0+vGyOP6Cl+QipTlKKb/W fy7JhTgtrMhL6ZjriO09PicuIQZYzq0BgiWWkNzy/ymfBWvIAQQOQM/82IMvaC6dfYjS 4kY6g489MHZ91f2qfUH9KwbX70qAEZSutednQZOpKovqS3KOYdfcg/LUW1DcaxnCFDjc Xdew== X-Received: by 10.194.216.38 with SMTP id on6mr2088068wjc.14.1384437994235; Thu, 14 Nov 2013 06:06:34 -0800 (PST) Received: from [192.168.42.82] (166-236.197-178.cust.bluewin.ch. [178.197.236.166]) by mx.google.com with ESMTPSA id ey4sm7198337wic.11.2013.11.14.06.06.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 14 Nov 2013 06:06:33 -0800 (PST) Message-ID: <5284D8E1.3000504@gmail.com> Date: Thu, 14 Nov 2013 15:06:25 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [RFC] New port to arm64-efi References: <1384432539-7696-1-git-send-email-leif.lindholm@linaro.org> In-Reply-To: <1384432539-7696-1-git-send-email-leif.lindholm@linaro.org> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2POLXRQGCFCFWMFHAPDWF" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 14:06:48 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2POLXRQGCFCFWMFHAPDWF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Good work. Few minor problems: On 14.11.2013 13:35, Leif Lindholm wrote: > + > + grub_arch_sync_caches_real (address, len); Why not do alignment here? You could align for both dcache and icache, this simplifies asm part and makes it a bit more robust. > + grub_uint32_t insword, insmask; > + grub_ssize_t offset, offset_low, offset_high; > + > + insword =3D grub_le_to_cpu32 (*place); > + insmask =3D 0xfc000000; > + > + offset_low =3D -(1 << 27); > + offset_high =3D (1 << 27) - 1; > + Should be declared as const. > +int grub_setjmp (grub_jmp_buf env) __attribute__ ((returns_twice)); We have a macro for returns_twice. > +/* Unaligned accesses only supported if MMU enabled */ > +#define GRUB_HAVE_UNALIGNED_ACCESS 1 > + Feels like it shouldn't be defined: #undef GRUB_HAVE_UNALIGNED_ACCESS Not defining those does no harm unless there is some weird unaligned devi= ce. > diff --git a/util/grub-install.in b/util/grub-install.in > index 4cddf5e..a882acf 100644 > --- a/util/grub-install.in > +++ b/util/grub-install.in > @@ -280,6 +280,8 @@ if [ x$source_directory =3D x ]; then > ;; > x"arm"*) > target=3D"arm-uboot";; > + x"aarch64"*) > + target=3D"arm64-efi";; > *) > gettext "Unable to determine your platform. Use --target." ; > echo ;; > @@ -434,6 +436,8 @@ if [ x"$grub_modinfo_platform" =3D xefi ]; then > efi_file=3DBOOTIA64.EFI ;; > arm) > efi_file=3DBOOTARM.EFI ;; > + arm64) > + efi_file=3DBOOTAARCH64.EFI ;; > esac > else > # It is convenient for each architecture to have a different > @@ -450,6 +454,8 @@ if [ x"$grub_modinfo_platform" =3D xefi ]; then > efi_file=3Dgrubia64.efi ;; > arm) > efi_file=3Dgrubarm.efi ;; > + arm64) > + efi_file=3Dgrubarm64.efi ;; > *) > efi_file=3Dgrub.efi ;; > esac I'l need to merge those into install_c. Will you be available to test it?= ------enig2POLXRQGCFCFWMFHAPDWF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKE2OEACgkQmBXlbbo5nOtcrAEAnn22EfGF4++zg0qxAmgWVddO K2y0xt0fnZdWY3QXTtsA/1yUnvghzfIAD0NgwaCx19TF4O880MknbUHdjelf8ZOd =ZWTz -----END PGP SIGNATURE----- ------enig2POLXRQGCFCFWMFHAPDWF--