From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VhfLP-0007By-GN for mharc-grub-devel@gnu.org; Sat, 16 Nov 2013 07:51:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhfLI-00079f-2Q for grub-devel@gnu.org; Sat, 16 Nov 2013 07:51:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhfLC-000461-8a for grub-devel@gnu.org; Sat, 16 Nov 2013 07:51:16 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:48753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhfLC-00045x-1K for grub-devel@gnu.org; Sat, 16 Nov 2013 07:51:10 -0500 Received: by mail-ea0-f180.google.com with SMTP id b11so1788406eae.25 for ; Sat, 16 Nov 2013 04:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=9NjvsPmiBn0elX+ubg2vNa1JfWSG2/+3TSF/PGVJoGA=; b=Ek+zjkpjeoUMiJ3HhHuhaHuBIdgAgRY6CALckiN+1NU1OPu+6PPZWag3mayR7rzvCo kq9pD9ktgynBuyYPJVRqhBLG+B4MZ7jwqdYZE78wPhque9NbSd8nKrDi61p7PT1IduXR 37rIJfP44Gy6lrlDKq3tFdYz79gg9Y1WNA9ADj3AUhBfNgSH92H8I6T1RVt8Kua8SfCg IVt8L4Hkp8iOkLScjjy8y30CQYhshiinjEnVQRm4V0eNt4aAMgk22mr8JTrmx/UP8RML ZbK8q7c0HlBDwMmq+PiOjL74zCyh6HLYSDuM0jeBQAymWUJ4CKNnX7ZeSKBR8rNNRlgD x/5Q== X-Received: by 10.14.183.72 with SMTP id p48mr263738eem.21.1384606269129; Sat, 16 Nov 2013 04:51:09 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id v45sm16502003eef.11.2013.11.16.04.51.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Nov 2013 04:51:08 -0800 (PST) Message-ID: <52876A3B.8060804@gmail.com> Date: Sat, 16 Nov 2013 13:51:07 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] restore -nostdlib for libgcc symbols tests References: <528632AF.8090303@gmail.com> <1384577384-30226-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1384577384-30226-1-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2CDSMUJMRABUVNCGORTCX" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2013 12:51:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CDSMUJMRABUVNCGORTCX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16.11.2013 05:49, Andrey Borzenkov wrote: >> -static shouldn't create problems. Adding -nostdlib like I proposed >> should solve the problem. >=20 > Right, it was fallout of "plug the leakage" patch. I think below > patch is more aligned with the rest of code. >=20 > Commit 24f4e57c4684471da088c504dec0380886eece0c plugged leakage > of CFLAGS between individual tests, which broke test for libgcc > symbols. It needs -nostdlib which was set in previous test and > inherited before. Set it explicitly. >=20 Go ahead > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/configure.ac b/configure.ac > index 2c4f019..1842910 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -815,9 +815,9 @@ LIBS=3D"$TARGET_LIBGCC" > grub_ASM_USCORE > if test "x$TARGET_APPLE_LINKER" =3D x0 ; then > if test x$grub_cv_asm_uscore =3D xyes; then > -CFLAGS=3D"$TARGET_CFLAGS -Wl,--defsym,_abort=3D_main" > +CFLAGS=3D"$TARGET_CFLAGS -nostdlib -Wl,--defsym,_abort=3D_main" > else > -CFLAGS=3D"$TARGET_CFLAGS -Wl,--defsym,abort=3Dmain" > +CFLAGS=3D"$TARGET_CFLAGS -nostdlib -Wl,--defsym,abort=3Dmain" > fi > fi > =20 >=20 ------enig2CDSMUJMRABUVNCGORTCX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKHajsACgkQmBXlbbo5nOtw/wD+MSdwOzlEf6iGNpReaMjXIF4u yezeRr+1v1Yi8bo7/jgA/A61tzcbBNBWcbZFuGfYF1bt+mWAQl4UYfpGWNzJUwG9 =2SZo -----END PGP SIGNATURE----- ------enig2CDSMUJMRABUVNCGORTCX--