From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] MIPS grub_machine_get_bootlocation arguments are used
Date: Sat, 16 Nov 2013 13:51:54 +0100 [thread overview]
Message-ID: <52876A6A.7000604@gmail.com> (raw)
In-Reply-To: <1384579551-31536-1-git-send-email-arvidjaar@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Go ahead
On 16.11.2013 06:25, Andrey Borzenkov wrote:
> ---
> grub-core/kern/mips/arc/init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/grub-core/kern/mips/arc/init.c b/grub-core/kern/mips/arc/init.c
> index f12026e..cb6c228 100644
> --- a/grub-core/kern/mips/arc/init.c
> +++ b/grub-core/kern/mips/arc/init.c
> @@ -355,8 +355,7 @@ get_device_name_iter (grub_disk_t disk __attribute__ ((unused)),
> }
>
> void
> -grub_machine_get_bootlocation (char **device __attribute__ ((unused)),
> - char **path __attribute__ ((unused)))
> +grub_machine_get_bootlocation (char **device, char **path)
> {
> char *loaddev = boot_location;
> char *pptr, *partptr;
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
prev parent reply other threads:[~2013-11-16 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 5:25 [PATCH] MIPS grub_machine_get_bootlocation arguments are used Andrey Borzenkov
2013-11-16 12:51 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52876A6A.7000604@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).