From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VhgTC-0007Mr-Vu for mharc-grub-devel@gnu.org; Sat, 16 Nov 2013 09:03:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhgT6-0007LV-2x for grub-devel@gnu.org; Sat, 16 Nov 2013 09:03:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhgT0-0000Xr-PH for grub-devel@gnu.org; Sat, 16 Nov 2013 09:03:24 -0500 Received: from mail-ea0-x229.google.com ([2a00:1450:4013:c01::229]:50871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhgT0-0000XM-Iu for grub-devel@gnu.org; Sat, 16 Nov 2013 09:03:18 -0500 Received: by mail-ea0-f169.google.com with SMTP id l9so1548355eaj.28 for ; Sat, 16 Nov 2013 06:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=MYU8UKTJav6KokIru6rNzJv3hxeLSWHJ90sCLF0PA04=; b=gR9/MNxbFs+9h22u7/Bdq2J/YkiZ4sNnIWd9qkWXznxy3uTAvpf3sieN9w+OrLz/fD IHZTgX7A2iaS+XmasagFpRSgCfjnZr7AO5WpT2xZ79jOVTw1Iu+nkz8B7NAu/k2DutmT P+zhMCVvmlVt8Br7HpClnlb0vqChCtrC7pWY7NSnNWUNO6SoaKV/V3fqo+jCip4cD4cC kgEDm5uPBl+JK5hcCiG72ZfyAwDUNTGFtshd2Yfa/dY9zPzCl1mDwdpQDn6Qg9lLrPM7 b8YVnLrF15xexlrumXMFcVgMUItHfrTPnoPvGyqDBhgZPlP5EdCsCfdZ3hWtMwiLHR4l zbww== X-Received: by 10.14.1.130 with SMTP id 2mr8079267eed.24.1384610597730; Sat, 16 Nov 2013 06:03:17 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id 8sm17048025eem.15.2013.11.16.06.03.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Nov 2013 06:03:17 -0800 (PST) Message-ID: <52877B24.2040002@gmail.com> Date: Sat, 16 Nov 2013 15:03:16 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm) References: <51F139FF.2030402@gmail.com> <51F13E82.7040207@gmail.com> <20130727074625.64ad89d2@opensuse.site> <51F34AE4.1080709@gmail.com> <20131115231325.1d3fa95a@opensuse.site> <5286C02B.9050404@gmail.com> <20131116123941.GC30374@rocoto.smurfnet.nu> <528769EF.9070207@gmail.com> <20131116130010.GD30374@rocoto.smurfnet.nu> <5287707F.5090207@gmail.com> <20131116135340.GE30374@rocoto.smurfnet.nu> In-Reply-To: <20131116135340.GE30374@rocoto.smurfnet.nu> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2EOGRDFLDKEGLBGEWQQPH" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::229 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2013 14:03:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EOGRDFLDKEGLBGEWQQPH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16.11.2013 14:53, Leif Lindholm wrote: > On Sat, Nov 16, 2013 at 02:17:51PM +0100, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >>> From an ABI perspective, grub_uboot_syscall is a veneer: >>> the only visible side effect it is permitted to have is to corrupt r1= 2. >>> >> According to wikipedia: >> "Subroutines must preserve the contents of r4 to r11 and the stack poi= nter." >> So changing r9 sounds to me like this is actually U-Boot bug and >> preserving it sounds like right way to handle it. >=20 > No. grub_uboot_syscall is not a subroutine - it is a veneer. > We have a specific reason to need to preserve r8, over and above what > the ABI says, because u-boot has hijacked it. >=20 > But now I went to look at the u-boot code, and suddenly I want to cry. > Commit fe1378a961e508b31b1f29a2bb08ba1dac063155 changes the register > reserved for global data from r8 to r9. Which means we need to preserve= > both since they didn't step the API version number. >=20 > *sigh* >=20 > Updated patch attached. Go ahead. >=20 > / > Leif >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2EOGRDFLDKEGLBGEWQQPH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKHeyQACgkQmBXlbbo5nOtlmwEAmTtMWOZ3yAExCyWavYuA66A+ GMPhjJeL4Hw9nHJ3TVgA/jhOs2MpvspZoU1HMTvZo221WOe2oHo7F8IQgMPkLtvp =vujM -----END PGP SIGNATURE----- ------enig2EOGRDFLDKEGLBGEWQQPH--