From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)
Date: Sat, 16 Nov 2013 15:45:05 +0100 [thread overview]
Message-ID: <528784F1.8060308@gmail.com> (raw)
In-Reply-To: <20131116142835.GF30374@rocoto.smurfnet.nu>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On 16.11.2013 15:28, Leif Lindholm wrote:
> Argh...
>
> I pushed the above, and almost immediately I realised that in this
> situation we also need to store u-boot's version of r9 on return:
>
> diff --git a/grub-core/kern/arm/uboot/startup.S b/grub-core/kern/arm/uboot/start
> index df1e329..26313ba 100644
> --- a/grub-core/kern/arm/uboot/startup.S
> +++ b/grub-core/kern/arm/uboot/startup.S
> @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall)
> mov lr, pc
> ldr pc, grub_uboot_syscall_ptr
> str r8, gd_backup
> + str r9, gd_backup + 4
>
> ldr r8, transition_space
> ldr lr, transition_space + 4
>
> Can I push this fix too?
>
But why does global pointer change at all?
What about exit function?
> /
> Leif
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-11-16 14:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 13:20 [PATCH] [ARM] Enable boot module for arm Francesco Lavra
2013-07-25 14:36 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-25 14:45 ` Francesco Lavra
2013-07-25 15:04 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-27 3:46 ` Andrey Borzenkov
2013-07-27 4:21 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-27 5:19 ` Andrey Borzenkov
2013-07-27 14:44 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-28 16:51 ` Andrey Borzenkov
2013-07-28 18:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-28 18:18 ` Andrey Borzenkov
2013-07-28 19:01 ` Andrey Borzenkov
2013-11-15 19:13 ` Andrey Borzenkov
2013-11-16 0:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 12:39 ` Leif Lindholm
2013-11-16 12:49 ` [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm) Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 13:00 ` Leif Lindholm
2013-11-16 13:17 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 13:27 ` Andrey Borzenkov
2013-11-16 13:53 ` Leif Lindholm
2013-11-16 14:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 14:28 ` Leif Lindholm
2013-11-16 14:45 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-11-16 14:45 ` Leif Lindholm
2013-11-16 15:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 15:23 ` Leif Lindholm
2013-11-16 15:31 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 12:54 ` [PATCH] [ARM] Enable boot module for arm Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528784F1.8060308@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).