From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vhh7o-0006gX-Jf for mharc-grub-devel@gnu.org; Sat, 16 Nov 2013 09:45:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhh7c-0006fS-T2 for grub-devel@gnu.org; Sat, 16 Nov 2013 09:45:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vhh7U-0003UZ-30 for grub-devel@gnu.org; Sat, 16 Nov 2013 09:45:16 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:41996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhh7T-0003U8-Rq for grub-devel@gnu.org; Sat, 16 Nov 2013 09:45:08 -0500 Received: by mail-ea0-f180.google.com with SMTP id b11so1871171eae.39 for ; Sat, 16 Nov 2013 06:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=TRLWbT5nvaFo9MjCiG17Upkwb3LpzA5EfH34gSESMmY=; b=xk0ZKkx3b3hRzxUFX+f9cwWXuB7uoRlBVH4NBp35T3Y62fBlcjyI5VYWCSuLggfqrY VIRAOCjJrL9NcCLy2fHS7tt1codjuao9C+HorwnaApyLiAYCVQyXRVD4npRdxarXSFxB CmTpVKB+yYgsg2py4XIR7v+hAQyZwKR0ICd3bh5sClKHpLuAHbzqJuVZUbGH5+j1ZLxA y7NVbBE6gfsuWyU0ePd/ycvM4UrGKw8Ynm8iyxtRW4bHL6fgP4vHaP8zuUPHIWBpdv2l P+3P1AuIdWK2StJ2UAY1ff5jMJ7LvYhWRrUMngodrTKCxlaGn7a/UV8yHZuGyokS/Pdw 1RXA== X-Received: by 10.14.113.137 with SMTP id a9mr8209664eeh.3.1384613106711; Sat, 16 Nov 2013 06:45:06 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id 1sm17405324eeg.4.2013.11.16.06.45.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Nov 2013 06:45:05 -0800 (PST) Message-ID: <528784F1.8060308@gmail.com> Date: Sat, 16 Nov 2013 15:45:05 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm) References: <20130727074625.64ad89d2@opensuse.site> <51F34AE4.1080709@gmail.com> <20131115231325.1d3fa95a@opensuse.site> <5286C02B.9050404@gmail.com> <20131116123941.GC30374@rocoto.smurfnet.nu> <528769EF.9070207@gmail.com> <20131116130010.GD30374@rocoto.smurfnet.nu> <5287707F.5090207@gmail.com> <20131116135340.GE30374@rocoto.smurfnet.nu> <52877B24.2040002@gmail.com> <20131116142835.GF30374@rocoto.smurfnet.nu> In-Reply-To: <20131116142835.GF30374@rocoto.smurfnet.nu> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2CKBDESVICROEJGSHLQGG" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2013 14:45:26 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CKBDESVICROEJGSHLQGG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16.11.2013 15:28, Leif Lindholm wrote: > Argh... >=20 > I pushed the above, and almost immediately I realised that in this > situation we also need to store u-boot's version of r9 on return: >=20 > diff --git a/grub-core/kern/arm/uboot/startup.S b/grub-core/kern/arm/ub= oot/start > index df1e329..26313ba 100644 > --- a/grub-core/kern/arm/uboot/startup.S > +++ b/grub-core/kern/arm/uboot/startup.S > @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall) > mov lr, pc > ldr pc, grub_uboot_syscall_ptr > str r8, gd_backup > + str r9, gd_backup + 4 > =20 > ldr r8, transition_space > ldr lr, transition_space + 4 >=20 > Can I push this fix too? >=20 But why does global pointer change at all? What about exit function? > / > Leif ------enig2CKBDESVICROEJGSHLQGG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKHhPEACgkQmBXlbbo5nOsfzQD/cCUzDkPBVVSI56AvFJq2fGRD tsq1Z/qhnnRM3+nKXo0A/05+3lXPMkoKRD9pW61jfuNqu72f8Xj9vMGzxi/wM+aw =abwu -----END PGP SIGNATURE----- ------enig2CKBDESVICROEJGSHLQGG--