From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VhhfU-0006jS-Ou for mharc-grub-devel@gnu.org; Sat, 16 Nov 2013 10:20:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhhfO-0006jG-Gk for grub-devel@gnu.org; Sat, 16 Nov 2013 10:20:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhhfJ-0004ni-5j for grub-devel@gnu.org; Sat, 16 Nov 2013 10:20:10 -0500 Received: from mail-qa0-x22e.google.com ([2607:f8b0:400d:c00::22e]:46114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhhfJ-0004jk-0h for grub-devel@gnu.org; Sat, 16 Nov 2013 10:20:05 -0500 Received: by mail-qa0-f46.google.com with SMTP id f11so244351qae.19 for ; Sat, 16 Nov 2013 07:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=CAEnnBUlkb68zHtzitUIVKHCy0H4caf7e1Hn2PNoVSQ=; b=mQGuxk8s6B/CFIzqqrb20AnYEZSGzJeC7QqjfQTuhg9K8rMnDEqaNHmYZ0gzy0byPN mt9mXYyfzglJ8Grco73bTHqo6zoLupUdNyZau8oxChHllZjPoS6t2U5/3/tljfoHUjyf Ndg+qmxQAmnjPS1/gtq9KK3eq/TuJDDGi+9qSGyWHMSlSE8Axt71zzDqNsALh8vI0UBD MhUFmShdZQFKUXfjxhLOzgdXOHFaL4mCBMAJSvG3VO/hOZB602HJYaOPjFb444OuZ+DE X0016ViXwFpvCuyoba2ykJ2LAB3W/60uDU4ZKMJLuesbLzK2G3ksUJHWLUeyBm2qaOaO z35w== X-Received: by 10.224.171.66 with SMTP id g2mr19336194qaz.54.1384615204211; Sat, 16 Nov 2013 07:20:04 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id a45sm521424eem.6.2013.11.16.07.20.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Nov 2013 07:20:03 -0800 (PST) Message-ID: <52878D14.5050909@gmail.com> Date: Sat, 16 Nov 2013 16:19:48 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm) References: <51F34AE4.1080709@gmail.com> <20131115231325.1d3fa95a@opensuse.site> <5286C02B.9050404@gmail.com> <20131116123941.GC30374@rocoto.smurfnet.nu> <528769EF.9070207@gmail.com> <20131116130010.GD30374@rocoto.smurfnet.nu> <5287707F.5090207@gmail.com> <20131116135340.GE30374@rocoto.smurfnet.nu> <52877B24.2040002@gmail.com> <20131116142835.GF30374@rocoto.smurfnet.nu> <20131116144531.GG30374@rocoto.smurfnet.nu> In-Reply-To: <20131116144531.GG30374@rocoto.smurfnet.nu> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2DBNBCDPTVWHEPCUPWEVN" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c00::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2013 15:20:16 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DBNBCDPTVWHEPCUPWEVN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16.11.2013 15:45, Leif Lindholm wrote: > On Sat, Nov 16, 2013 at 03:28:35PM +0100, Leif Lindholm wrote: >> I pushed the above, and almost immediately I realised that in this >> situation we also need to store u-boot's version of r9 on return: >> >> diff --git a/grub-core/kern/arm/uboot/startup.S b/grub-core/kern/arm/u= boot/start >> index df1e329..26313ba 100644 >> --- a/grub-core/kern/arm/uboot/startup.S >> +++ b/grub-core/kern/arm/uboot/startup.S >> @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall) >> mov lr, pc >> ldr pc, grub_uboot_syscall_ptr >> str r8, gd_backup >> + str r9, gd_backup + 4 >> =20 >> ldr r8, transition_space >> ldr lr, transition_space + 4 >> >> Can I push this fix too? >=20 > Umm, at second thought - the gd pointer(s) wouldn't be changing. > So the correct fix would rather be to=20 > - str r8, gd_backup > ? >=20 Was this tested? > / > Leif >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2DBNBCDPTVWHEPCUPWEVN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKHjSIACgkQmBXlbbo5nOthtAD9ExIZ0J3QvIZ/e+zEMaMTLWMy BtEuSe8+HLDXMZ6/mwsA/RMMpzFaTPeVSxrixUV55+KKY2skOKHtUugPHTaowOoo =UVMB -----END PGP SIGNATURE----- ------enig2DBNBCDPTVWHEPCUPWEVN--