From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vhhqr-0001tB-P1 for mharc-grub-devel@gnu.org; Sat, 16 Nov 2013 10:32:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhhqk-0001rK-0r for grub-devel@gnu.org; Sat, 16 Nov 2013 10:31:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vhhqe-0008Bj-MU for grub-devel@gnu.org; Sat, 16 Nov 2013 10:31:53 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:43258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhhqe-0008BY-FL for grub-devel@gnu.org; Sat, 16 Nov 2013 10:31:48 -0500 Received: by mail-ea0-f180.google.com with SMTP id b11so1910703eae.11 for ; Sat, 16 Nov 2013 07:31:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=zdqY6FmKq67OHLpohPh1ZEu4O6bqmi8FY8tn8RLQYjQ=; b=P9etqYLvvMynd41g2qmsT22EpxMnLFkYMtBpYcmrQHuyKM7ykhGcX9xXHtpQyfKvUt pwW7LaNUzCxqOOO7pH7EBs5LmqygPD2zHdWeZ1rOa/VPW1RA1M40mQuS4RTN9WjJzSPZ jIr5eJz2ypvRSTwlHgPDqbSRHbhxkiFY1MXW841pUADPR5ruZX42cdIwsYX++8C+c7la 17tlBwPuLVfE0jLQYn1ZGU68XAlNYewiWuYLTesi4Fxqi/o/+qNLI97HaHQ8J75Xe8bz UhQizjvZMWcntFO+tj9510O5zeYE3IPveWV3pkj4Ru5ppNQWDXoWrIUTRiV7MwOY7wo0 UIkg== X-Received: by 10.15.61.66 with SMTP id h42mr254101eex.62.1384615907391; Sat, 16 Nov 2013 07:31:47 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id k7sm17729864eeg.13.2013.11.16.07.31.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Nov 2013 07:31:46 -0800 (PST) Message-ID: <52878FD1.3020202@gmail.com> Date: Sat, 16 Nov 2013 16:31:29 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm) References: <5286C02B.9050404@gmail.com> <20131116123941.GC30374@rocoto.smurfnet.nu> <528769EF.9070207@gmail.com> <20131116130010.GD30374@rocoto.smurfnet.nu> <5287707F.5090207@gmail.com> <20131116135340.GE30374@rocoto.smurfnet.nu> <52877B24.2040002@gmail.com> <20131116142835.GF30374@rocoto.smurfnet.nu> <20131116144531.GG30374@rocoto.smurfnet.nu> <52878D14.5050909@gmail.com> <20131116152327.GJ30374@rocoto.smurfnet.nu> In-Reply-To: <20131116152327.GJ30374@rocoto.smurfnet.nu> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2GXJPICHLNGCLQQIKGQPE" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2013 15:31:59 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GXJPICHLNGCLQQIKGQPE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16.11.2013 16:23, Leif Lindholm wrote: > On Sat, Nov 16, 2013 at 04:19:48PM +0100, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >>>> @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall) >>>> mov lr, pc >>>> ldr pc, grub_uboot_syscall_ptr >>>> str r8, gd_backup >>>> + str r9, gd_backup + 4 >>>> =20 >>>> ldr r8, transition_space >>>> ldr lr, transition_space + 4 >>>> >>>> Can I push this fix too? >>> >>> Umm, at second thought - the gd pointer(s) wouldn't be changing. >>> So the correct fix would rather be to=20 >>> - str r8, gd_backup >>> ? >>> >> Was this tested? >=20 > Tested on Ian's qemu, with an "mmc" block device.. >=20 Go ahead. > / > Leif >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2GXJPICHLNGCLQQIKGQPE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKHj+EACgkQmBXlbbo5nOs0BQEAlhZeW36F304SsIY+itibCK6K 99tOo3UQi9QGDSnc27EA/3MpaatwBtYBc6c0uY15pFGiLZtRDBhDwiE4fs4N1GZq =eedb -----END PGP SIGNATURE----- ------enig2GXJPICHLNGCLQQIKGQPE--