From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vhm0f-0004xL-OA for mharc-grub-devel@gnu.org; Sat, 16 Nov 2013 14:58:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhm0Z-0004vb-2x for grub-devel@gnu.org; Sat, 16 Nov 2013 14:58:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vhm0S-0005y6-No for grub-devel@gnu.org; Sat, 16 Nov 2013 14:58:19 -0500 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:53693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhm0S-0005xz-GJ for grub-devel@gnu.org; Sat, 16 Nov 2013 14:58:12 -0500 Received: by mail-ea0-f176.google.com with SMTP id m14so1592695eaj.7 for ; Sat, 16 Nov 2013 11:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=x1OSkjBaUEXQ+VdcfecyD1N8bLrnqTx35XlgOqMBikQ=; b=AvB8y2tkQMZsj3kHy8HkyyT3R0I5dYt5+yd4XCFWM+BiQq8qvjTapE4JvGQeYsrGYt 4J4ekB/tjoZRPSWY1kDEDbQ3dSuNgM+0EFLdrPc9Y8Ib/TamfOdHP9PUC+MCQ8jlBcN+ x7F9mKPfc4TpGozkjlF090SibD4eTUOibFEN6K5+rjth51g/iPmeD54JmytgUCvBIk5r XjiHOt4EAweFsR++uIce5lUs2HGKslt37XZ8MbEa09wj0A7C+KbTFjE3Ln5/ocw/aJwx IcUHKaGzl6VpOjW7CzOnqJPq1NUxv4GRLGLH4XYWKxyh1oqVXyHoqVmMrBBAxxO0lNSO adYg== X-Received: by 10.14.1.130 with SMTP id 2mr10069194eed.24.1384631891451; Sat, 16 Nov 2013 11:58:11 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id 44sm19796705eek.5.2013.11.16.11.58.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Nov 2013 11:58:10 -0800 (PST) Message-ID: <5287CE51.4080701@gmail.com> Date: Sat, 16 Nov 2013 20:58:09 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [RFC] New port to arm64-efi References: <1384432539-7696-1-git-send-email-leif.lindholm@linaro.org> <5284D8E1.3000504@gmail.com> <20131114153112.GH13408@rocoto.smurfnet.nu> In-Reply-To: <20131114153112.GH13408@rocoto.smurfnet.nu> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2JSBNSHNBBTTFNPQRMHOK" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2013 19:58:24 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JSBNSHNBBTTFNPQRMHOK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I've imported the port to a branch leiflindholm/arm64 applying few fixes I mentioned. Could you test it? On 14.11.2013 16:31, Leif Lindholm wrote: > On Thu, Nov 14, 2013 at 03:06:25PM +0100, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >> Good work. Few minor problems: >> On 14.11.2013 13:35, Leif Lindholm wrote: >>> + >>> + grub_arch_sync_caches_real (address, len); >> Why not do alignment here? You could align for both dcache and icache,= >> this simplifies asm part and makes it a bit more robust. >>> + grub_uint32_t insword, insmask; >>> + grub_ssize_t offset, offset_low, offset_high; >>> + >>> + insword =3D grub_le_to_cpu32 (*place); >>> + insmask =3D 0xfc000000; >>> + >>> + offset_low =3D -(1 << 27); >>> + offset_high =3D (1 << 27) - 1; >>> + >> Should be declared as const. > =20 > Good point. >=20 >>> +int grub_setjmp (grub_jmp_buf env) __attribute__ ((returns_twice)); >> We have a macro for returns_twice. >=20 > Ah, I missed when that was introduced. Will fix. >=20 >>> +/* Unaligned accesses only supported if MMU enabled */ >>> +#define GRUB_HAVE_UNALIGNED_ACCESS 1 >>> + >> Feels like it shouldn't be defined: >> #undef GRUB_HAVE_UNALIGNED_ACCESS >> Not defining those does no harm unless there is some weird unaligned d= evice. >=20 > Ok. > MMU is always enabled with UEFI though. >=20 >>> diff --git a/util/grub-install.in b/util/grub-install.in >>> index 4cddf5e..a882acf 100644 >>> --- a/util/grub-install.in >>> +++ b/util/grub-install.in >>> @@ -280,6 +280,8 @@ if [ x$source_directory =3D x ]; then >>> ;; >>> x"arm"*) >>> target=3D"arm-uboot";; >>> + x"aarch64"*) >>> + target=3D"arm64-efi";; >>> *) >>> gettext "Unable to determine your platform. Use --target." ; >>> echo ;; >>> @@ -434,6 +436,8 @@ if [ x"$grub_modinfo_platform" =3D xefi ]; then >>> efi_file=3DBOOTIA64.EFI ;; >>> arm) >>> efi_file=3DBOOTARM.EFI ;; >>> + arm64) >>> + efi_file=3DBOOTAARCH64.EFI ;; >>> esac >>> else >>> # It is convenient for each architecture to have a different >>> @@ -450,6 +454,8 @@ if [ x"$grub_modinfo_platform" =3D xefi ]; then >>> efi_file=3Dgrubia64.efi ;; >>> arm) >>> efi_file=3Dgrubarm.efi ;; >>> + arm64) >>> + efi_file=3Dgrubarm64.efi ;; >>> *) >>> efi_file=3Dgrub.efi ;; >>> esac >> I'l need to merge those into install_c. Will you be available to test = it? >=20 > Sure. >=20 > / > Leif >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2JSBNSHNBBTTFNPQRMHOK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKHzlEACgkQmBXlbbo5nOsSrQD/TfOBGivwcyRcC34W+Q9hIiVn SowbZCOIIJVT8xFqFm8A/jAu3PXwPcE1ljvlGLemUk+TjjukiVp373/oPaFFiO/T =afJ9 -----END PGP SIGNATURE----- ------enig2JSBNSHNBBTTFNPQRMHOK--